From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] Added package xcalib
Date: Fri, 18 Nov 2016 15:10:15 -0500
Message-ID: <20161118201015.GB16535@jasmine>
References: <c90a402f9fb330dcdafd7cd5a08fd169@mykolab.ch>
	<20161115193543.GB420@jasmine>
	<187506c7022391ac0766a444f73657df@mykolab.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50654)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1c7pUM-00080B-2W
	for guix-devel@gnu.org; Fri, 18 Nov 2016 15:10:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1c7pUI-0001ZB-UY
	for guix-devel@gnu.org; Fri, 18 Nov 2016 15:10:22 -0500
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:40785)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <leo@famulari.name>) id 1c7pUI-0001Z7-Q7
	for guix-devel@gnu.org; Fri, 18 Nov 2016 15:10:18 -0500
Content-Disposition: inline
In-Reply-To: <187506c7022391ac0766a444f73657df@mykolab.ch>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Petter <petter@mykolab.ch>
Cc: guix-devel@gnu.org

On Wed, Nov 16, 2016 at 01:37:04AM +0100, Petter wrote:
> I have worked through the issues you brought up, and it should at least be
> better now. Maybe even good.

It was already good, now it's very good :)

> There is no indication of GPL v2 or later in the project though.

Okay.

Pushed as 01278f16a9b with the following two changes:

> +                  (replace 'install
> +                    (lambda* (#:key outputs #:allow-other-keys)
> +                      (let* ((out (assoc-ref outputs "out"))
> +                             (bin (string-append out "/bin")))
> +                        (mkdir-p bin)
> +                        (install-file "xcalib" bin))))

(install-file) does (mkdir-p) itself, so I removed the redundant
(mkdir-p). It's defined in (guix build utils) if you are interested to
see.

> +                  (add-after 'install 'install-doc
> +                    (lambda* (#:key outputs #:allow-other-keys)
> +                      (let ((doc (string-append(assoc-ref outputs "out")
> +                                               "/share/doc/")))
                                                              ^
I added "xcalib" to the end of the path here -----------------|

So, when a user installs xcalib into their profile, the README will be
at ~/.guix-profile/share/doc/xcalib/README, instead of
~/.guix-profile/share/doc/README.