From: Leo Famulari <leo@famulari.name>
To: Petter <petter@mykolab.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Added package xcalib
Date: Fri, 18 Nov 2016 15:10:15 -0500 [thread overview]
Message-ID: <20161118201015.GB16535@jasmine> (raw)
In-Reply-To: <187506c7022391ac0766a444f73657df@mykolab.ch>
On Wed, Nov 16, 2016 at 01:37:04AM +0100, Petter wrote:
> I have worked through the issues you brought up, and it should at least be
> better now. Maybe even good.
It was already good, now it's very good :)
> There is no indication of GPL v2 or later in the project though.
Okay.
Pushed as 01278f16a9b with the following two changes:
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (bin (string-append out "/bin")))
> + (mkdir-p bin)
> + (install-file "xcalib" bin))))
(install-file) does (mkdir-p) itself, so I removed the redundant
(mkdir-p). It's defined in (guix build utils) if you are interested to
see.
> + (add-after 'install 'install-doc
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((doc (string-append(assoc-ref outputs "out")
> + "/share/doc/")))
^
I added "xcalib" to the end of the path here -----------------|
So, when a user installs xcalib into their profile, the README will be
at ~/.guix-profile/share/doc/xcalib/README, instead of
~/.guix-profile/share/doc/README.
next prev parent reply other threads:[~2016-11-18 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 16:05 [PATCH] Added package xcalib Petter
2016-11-15 19:35 ` Leo Famulari
2016-11-16 0:37 ` Petter
2016-11-18 20:10 ` Leo Famulari [this message]
2016-11-19 17:14 ` Petter
2016-11-19 18:36 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118201015.GB16535@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=petter@mykolab.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.