From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Patterson <ajpatter@uwaterloo.ca>
Subject: Re: [PATCH] tests: Don't check file-systems in container tests.
Date: Sun, 13 Nov 2016 10:51:27 -0500
Message-ID: <20161113105127.5a6c98be@uwaterloo.ca>
References: <20161112222028.235925fb@uwaterloo.ca>
	<87y40nh9ew.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36262)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ajpatter@uwaterloo.ca>) id 1c5x4C-0004Cs-Gb
	for guix-devel@gnu.org; Sun, 13 Nov 2016 10:51:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ajpatter@uwaterloo.ca>) id 1c5x49-0002ys-Er
	for guix-devel@gnu.org; Sun, 13 Nov 2016 10:51:36 -0500
In-Reply-To: <87y40nh9ew.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

On Sun, 13 Nov 2016 13:05:43 +0100
ludo@gnu.org (Ludovic Court=C3=A8s) wrote:

> Hi,
>=20
> Andy Patterson <ajpatter@uwaterloo.ca> skribis:
>=20
> > The containers test was hanging for me, and this patch fixed the
> > problem. =20
>=20
> [...]
>=20
> > From 945ad44acf489b7f3a398d4ab739ec2b48477502 Mon Sep 17 00:00:00
> > 2001 From: Andy Patterson <ajpatter@uwaterloo.ca>
> > Date: Sat, 12 Nov 2016 22:10:01 -0500
> > Subject: [PATCH] tests: Don't check file-systems in container tests.
> >
> > * tests/containers.scm ("call-with-container, mnt namespace"): Don't
> > check file-system in 'call-with-container' call.
> > * tests/containers.scm
> > ("call-with-container, mnt namespace, wrong bindmount"): Likewise.
> > ---
> >  tests/containers.scm | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/containers.scm b/tests/containers.scm
> > index ccd122a..745b56b 100644
> > --- a/tests/containers.scm
> > +++ b/tests/containers.scm
> > @@ -84,7 +84,8 @@
> >     (call-with-container (list (file-system
> >                                  (device "none")
> >                                  (mount-point "/testing")
> > -                                (type "tmpfs")))
> > +                                (type "tmpfs")
> > +                                (check? #f))) =20
>=20
> Do you know exactly how/why it was hanging?  I imagine
> =E2=80=98mount-file-system=E2=80=99 would try to invoke fsck.tmpfs, which=
 doesn=E2=80=99t
> exist, thus we get a REPL, which hangs forever.
>=20

I did get a REPL (in the log file), so you're probably right.

> I guess the real question is why I didn=E2=80=99t experience it, hmm=E2=
=80=A6
>=20

Not sure, but I first noticed the problem when guix-devel was building
during a system reconfigure. That might be easier to reproduce.

> Thanks,
> Ludo=E2=80=99.

Thanks.

--
Andy