From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/3] gnu: Add python-pypdf2.
Date: Tue, 8 Nov 2016 18:55:24 -0500
Message-ID: <20161108235524.GA25046@jasmine>
References: <1478641022-30723-1-git-send-email-h.goebel@crazy-compilers.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56518)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1c4GEn-0002Tg-2H
	for guix-devel@gnu.org; Tue, 08 Nov 2016 18:55:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1c4GEj-0004sa-5W
	for guix-devel@gnu.org; Tue, 08 Nov 2016 18:55:33 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:49972)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <leo@famulari.name>) id 1c4GEi-0004sN-VW
	for guix-devel@gnu.org; Tue, 08 Nov 2016 18:55:29 -0500
Content-Disposition: inline
In-Reply-To: <1478641022-30723-1-git-send-email-h.goebel@crazy-compilers.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org

On Tue, Nov 08, 2016 at 10:37:00PM +0100, Hartmut Goebel wrote:
> * gnu/packages/pdf.scm(python-pypdf2, python2-pypdf2): New variables.

> +    (arguments
> +      '(#:tests? #f))  ; no tests

Are these files not relevant?

https://github.com/mstamy2/PyPDF2/tree/master/Tests

> +    (home-page "http://mstamy2.github.com/PyPDF2")
> +    (synopsis "Pure-Python PDF toolkit")

I would replace the hyphen in "Pure-Python" with a space.

> +    (description "A Pure-Python library built as a PDF toolkit.  It is capable

Same here.

> +of:
> +
> +@itemize
> +@item extracting document information (title, author, …)
> +@item splitting documents page by page
> +@item merging documents page by page
> +@item cropping pages
> +@item merging multiple pages into a single page
> +@item encrypting and decrypting PDF files
> +@item and more!
> +@end itemize

We have to use enumerate instead of itemize due to a limitation in
Guile's texinfo -> HTML converter. This is fixed in Guile, but not in
the version that we use currently, IIUC:

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=21772
https://lists.gnu.org/archive/html/guile-commits/2016-06/msg00341.html

$ git describe --contains bd65845497110b179456d4bfdf26854791f0a822
v2.1.4~95