From mboxrd@z Thu Jan  1 00:00:00 1970
From: Theodoros Foradis <theodoros.for@openmailbox.org>
Subject: [PATCH v5 0/1] gnu: Add plantuml.
Date: Mon,  7 Nov 2016 15:21:57 +0200
Message-ID: <20161107132158.4612-1-theodoros.for@openmailbox.org>
References: <87d1ibfgke.fsf@gnu.org>
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51608)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <theodoros.for@openmailbox.org>) id 1c3jwE-0002Sq-Aq
	for guix-devel@gnu.org; Mon, 07 Nov 2016 08:26:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <theodoros.for@openmailbox.org>) id 1c3jwA-00023m-20
	for guix-devel@gnu.org; Mon, 07 Nov 2016 08:26:14 -0500
Received: from smtp22.openmailbox.org ([62.4.1.56]:49223
	helo=smtp7.openmailbox.org)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <theodoros.for@openmailbox.org>)
	id 1c3jw9-00023F-Qj
	for guix-devel@gnu.org; Mon, 07 Nov 2016 08:26:09 -0500
In-Reply-To: <87d1ibfgke.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel@gnu.org

Roel Janssen writes:

> Theodoros Foradis writes:
>
>> Roel Janssen writes:
>>
>>> I tried running plantuml with the following snippet:
>>> @startuml
>>> A <..> B
>>> @enduml
>>>
>>> And it crashes because it attempts to run "/usr/bin/dot".
>>>
>>> With the following snippet, we replace this "/usr/bin/dot" dependency
>>> with the proper one from the graphviz input:
>>>
>>> (add-before 'build 'patch-usr-bin-dot
>>>   (lambda* (#:key inputs #:allow-other-keys)
>>>     (let ((dot (string-append (assoc-ref inputs "graphviz")
>>>                                "/bin/dot")))
>>>       (substitute*
>>>         "src/net/sourceforge/plantuml/cucadiagram/dot/GraphvizLinux.java"
>>>         (("/usr/bin/dot") dot)))))
>>>
>>
>> Nice catch! Thanks for testing that.
>>
>>> Could you add this snippet?
>>>
>>> Other than this, it works fine for me.
>>>
>>> Kind regards,
>>> Roel Janssen
>>
>> Let me know if I need to post an updated patch.
>
> Please do.  Have all comments been incorporated into this version of the
> patch?  If so, I guess we can push the version that includes my snippet,
> unless anyone still has any comments.
>

I have done all the changes suggested in the comments. I guess the
package is ready, if there are not any more. I have added your snippet
in this revised patch and lint finds no errors.

> Thanks!
>
> Kind regards,
> Roel Janssen

Regards,
-- 
Theodoros Foradis