From: Danny Milosavljevic <dannym@scratchpost.org>
To: cmmarusich@gmail.com
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 4/5] install: Extract procedure: install-grub-config.
Date: Sun, 6 Nov 2016 22:00:01 +0100 [thread overview]
Message-ID: <20161106220001.1ca62b07@scratchpost.org> (raw)
In-Reply-To: <20161102054815.11253-5-cmmarusich@gmail.com>
Thanks for this!
> -(define* (install-grub grub.cfg device mount-point)
> +(define (install-grub grub.cfg device mount-point)
> "Install GRUB with GRUB.CFG on DEVICE, which is assumed to be mounted on
> MOUNT-POINT.
>
> Note that the caller must make sure that GRUB.CFG is registered as a GC root
> so that the fonts, background images, etc. referred to by GRUB.CFG are not
> GC'd."
> + (install-grub-config grub.cfg mount-point)
> + (unless (zero? (system* "grub-install" "--no-floppy"
^^^ since you have touched it, maybe you know: How does it know which package's (which directory's) grub-install to invoke here?
next prev parent reply other threads:[~2016-11-06 21:00 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 10:07 Add system roll-back and switch-generation commands cmmarusich
2016-10-28 10:07 ` [PATCH 01/10] * gnu/system.scm (<boot-parameters>): Add 'store-device' and 'store-fs-mount-point' cmmarusich
2016-10-30 0:12 ` Ludovic Courtès
2016-10-30 9:41 ` Chris Marusich
2016-10-30 22:19 ` Ludovic Courtès
2016-11-02 5:48 ` Follow-up: Add system roll-back and switch-generation commands cmmarusich
2016-11-02 5:48 ` [PATCH 1/5] profiles: Extract a procedure for getting relative generation numbers cmmarusich
2016-11-06 16:56 ` Ludovic Courtès
2016-11-02 5:48 ` [PATCH 2/5] system: Rename previous-grub-entries to profile-grub-entries cmmarusich
2016-11-06 16:56 ` Ludovic Courtès
2016-11-02 5:48 ` [PATCH 3/5] system: Optionally limit the entries returned by profile-grub-entries cmmarusich
2016-11-06 16:57 ` Ludovic Courtès
2016-11-02 5:48 ` [PATCH 4/5] install: Extract procedure: install-grub-config cmmarusich
2016-11-06 16:59 ` Ludovic Courtès
2016-11-06 21:00 ` Danny Milosavljevic [this message]
2016-11-07 1:25 ` Chris Marusich
2016-11-07 10:32 ` Danny Milosavljevic
2016-11-02 5:48 ` [PATCH 5/5] system: Add 'guix system' actions: switch-generation and roll-back cmmarusich
2016-11-03 4:51 ` One more patch: doc: Add details to the 'guix system switch-generation' section Chris Marusich
2016-11-06 17:13 ` [PATCH 5/5] system: Add 'guix system' actions: switch-generation and roll-back Ludovic Courtès
2016-11-07 3:17 ` Chris Marusich
2016-11-03 0:19 ` [PATCH 01/10] * gnu/system.scm (<boot-parameters>): Add 'store-device' and 'store-fs-mount-point' Leo Famulari
2016-11-03 4:36 ` Chris Marusich
2016-11-03 10:35 ` Chris Marusich
2016-11-03 22:34 ` Danny Milosavljevic
2016-11-04 3:34 ` Chris Marusich
2016-11-04 3:55 ` Chris Marusich
2016-11-03 13:10 ` Fix a boot problem reported by ng0 cmmarusich
2016-11-03 13:10 ` [PATCH] system: Avoid using device paths in <menu-entry> device field cmmarusich
2016-11-04 15:49 ` Leo Famulari
2016-11-06 16:51 ` Ludovic Courtès
2016-10-28 10:07 ` [PATCH 02/10] Add 'device' field to <menu-entry> cmmarusich
2016-10-28 10:07 ` [PATCH 03/10] Refactor grub.cfg generation logic cmmarusich
2016-10-28 10:07 ` [PATCH 04/10] Extract procedure: relative-generation-spec->number cmmarusich
2016-10-28 10:07 ` [PATCH 05/10] Rename previous-grub-entries to grub-entries cmmarusich
2016-10-28 10:07 ` [PATCH 06/10] grub-entries: take a list of numbers on input cmmarusich
2016-10-28 10:07 ` [PATCH 07/10] Factor out procedure: install-grub-config cmmarusich
2016-10-28 10:07 ` [PATCH 08/10] Implement switch-generation and roll-back cmmarusich
2016-10-28 10:07 ` [PATCH 09/10] Rename grub-entries to profile-grub-entries cmmarusich
2016-10-28 10:07 ` [PATCH 10/10] Mention new 'guix system' features in the manual cmmarusich
2016-10-29 21:13 ` Add system roll-back and switch-generation commands Ludovic Courtès
2016-10-29 21:22 ` Chris Marusich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161106220001.1ca62b07@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=cmmarusich@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.