[PATCH 0/6] Enable lots of sqlalchemy features

[PATCH 0/6] Enable lots of sqlalchemy features

[Danny Milosavljevic]

Danny Milosavljevic (6):
  gnu: Enable python-psycopg2 support in python-sqlalchemy.
  gnu: Add python-pycodestyle.
  gnu: Add python-orderedmultidict.
  gnu: Add python-furl.
  gnu: Add python-flask-babel.
  gnu: Enable passlib, babel, cryptography, pyt, psycopg2, furl,
    flask-babel and pytest in python-sqlalchemy-utils

 gnu/packages/python.scm | 140 +++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 138 insertions(+), 2 deletions(-)

[PATCH 1/6] gnu: Enable python-psycopg2 support in python-sqlalchemy.

[Danny Milosavljevic]

* gnu/packages/python.scm (python-sqlalchemy): Modified.
---
 gnu/packages/python.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index b7c9e11..e52bc8d 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3807,6 +3807,8 @@ as the original project seems to have been abandoned circa 2007.")
        (base32
         "1l8qclhd0s90w3pvwhi5mjxdwr5j7gw7cjka2fx6f2vqmq7f4yb6"))))
     (build-system python-build-system)
+    (propagated-inputs
+     `(("python-psycopg2" ,python-psycopg2)))
     (native-inputs
      `(("python-cython" ,python-cython) ;for c extensions
        ("python-pytest" ,python-pytest)

Re: [PATCH 1/6] gnu: Enable python-psycopg2 support in python-sqlalchemy.

[Hartmut Goebel]

Am 03.11.2016 um 11:55 schrieb Danny Milosavljevic:
> +    (propagated-inputs
> +     `(("python-psycopg2" ,python-psycopg2)))

I don't think this is a good idea. sqlalchemy is database independent
requireing *any* database backend and the admin or the developer is
responsible for installing the required package.

If the system is not using postgresql, this is just useless. And if OTOH
we'd include all possible backends we'd end up with a huge package.

Or did I miss something?

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Re: [PATCH 1/6] gnu: Enable python-psycopg2 support in python-sqlalchemy.

[Danny Milosavljevic]

Hi,

On Thu, 3 Nov 2016 22:42:48 +0100
Hartmut Goebel <h.goebel@crazy-compilers.com> wrote:

> Am 03.11.2016 um 11:55 schrieb Danny Milosavljevic:
> > +    (propagated-inputs
> > +     `(("python-psycopg2" ,python-psycopg2)))  
> 
> I don't think this is a good idea. sqlalchemy is database independent
> requireing *any* database backend and the admin or the developer is
> responsible for installing the required package.
> 
> If the system is not using postgresql, this is just useless. And if OTOH
> we'd include all possible backends we'd end up with a huge package.
> 
> Or did I miss something?

No, I think you are right.

[PATCH 2/6] gnu: Add python-pycodestyle.

[Danny Milosavljevic]

* gnu/packages/python.scm (python-pycodestyle, python2-pycodestyle): New variables.
---
 gnu/packages/python.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index e52bc8d..86436fd 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3831,6 +3831,32 @@ simple and Pythonic domain language.")
 (define-public python2-sqlalchemy
   (package-with-python2 python-sqlalchemy))
 
+(define-public python-pycodestyle
+  (package
+    (name "python-pycodestyle")
+    (version "2.0.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "pycodestyle" version))
+        (sha256
+          (base32
+            "1rz2v8506mdjdyxcnv9ygiw6v0d4dqx8z5sjyjm0w2v32h5l5w1p"))))
+    (build-system python-build-system)
+    (home-page "https://pycodestyle.readthedocs.io/")
+    (synopsis "Python style guide checker")
+    (description "This package provides a Python style guide checker.")
+    (license license:expat)
+    (properties `((python2-variant . ,(delay python2-pycodestyle))))))
+
+(define-public python2-pycodestyle
+  (let ((base (package-with-python2 (strip-python2-variant
+                                     python-pycodestyle))))
+    (package (inherit base)
+      (native-inputs
+       `(("python2-setuptools" ,python2-setuptools)
+         ,@(package-native-inputs base))))))
+
 (define-public python-sqlalchemy-utils
   (package
     (name "python-sqlalchemy-utils")

Re: [PATCH 2/6] gnu: Add python-pycodestyle.

[Hartmut Goebel]

Am 03.11.2016 um 11:56 schrieb Danny Milosavljevic:
> +    (synopsis "Python style guide checker")
> +    (description "This package provides a Python style guide checker.")

This description is not much descriptive :-) What about taking the text
from the homepage:
"pycodestyle (formerly pep8) is a tool to check your Python code against
some of the style conventions in PEP 8
<http://www.python.org/dev/peps/pep-0008/>."

Otherwise LGTM

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

[PATCH 3/6] gnu: Add python-orderedmultidict.

[Danny Milosavljevic]

* gnu/packages/python.scm (python-orderedmultidict, python2-orderedmultidict): New variables.
---
 gnu/packages/python.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 86436fd..aee97cb 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3857,6 +3857,43 @@ simple and Pythonic domain language.")
        `(("python2-setuptools" ,python2-setuptools)
          ,@(package-native-inputs base))))))
 
+(define-public python-orderedmultidict
+  (package
+    (name "python-orderedmultidict")
+    (version "0.7.10")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "orderedmultidict" version))
+        (sha256
+          (base32
+            "1gvqk0jd432wsn88kq4svad68xz3r012jfpnhh9in7bqrkyxidky"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'fix-tests
+           (lambda _
+             (and (zero? (system* "touch" "tests/__init__.py"))))))))
+    (propagated-inputs
+     `(("python-six" ,python-six)))
+    (native-inputs
+     `(("python-pycodestyle" ,python-pycodestyle)))
+    (home-page "https://github.com/gruns/orderedmultidict")
+    (synopsis "Python Ordered Multivalue Dictionary - omdict.")
+    (description "This package contains Ordered Multivalue Dictionary - omdict
+- for Python.")
+    (license license:unlicense)
+    (properties `((python2-variant . ,(delay python2-orderedmultidict))))))
+
+(define-public python2-orderedmultidict
+  (let ((base (package-with-python2 (strip-python2-variant
+                                     python-orderedmultidict))))
+    (package (inherit base)
+      (native-inputs
+       `(("python2-setuptools" ,python2-setuptools)
+         ,@(package-native-inputs base))))))
+
 (define-public python-sqlalchemy-utils
   (package
     (name "python-sqlalchemy-utils")

Re: [PATCH 3/6] gnu: Add python-orderedmultidict.

[Hartmut Goebel]

Am 03.11.2016 um 11:56 schrieb Danny Milosavljevic:
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'fix-tests
> +           (lambda _
> +             (and (zero? (system* "touch" "tests/__init__.py"))))))))

Maybe add a note like: "The packages uses nosetest for running the
tests. Adding this initfile allows to run the test suite without
requiring nosetest."

> +    (synopsis "Python Ordered Multivalue Dictionary - omdict.")
Trailing period
> +    (description "This package contains Ordered Multivalue Dictionary - omdict
> +- for Python.")

Please be more verbose here. Maybe the description could be enhanced
using text from the setup.py:

    A multivalue dictionary is a dictionary that can store multiple
    values for the
    same key. An ordered multivalue dictionary is a multivalue
    dictionary that
    retains the order of insertions and deletions.


-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

[PATCH 4/6] gnu: Add python-furl.

[Danny Milosavljevic]

* gnu/packages/python.scm (python-furl, python2-furl): New variables.
---
 gnu/packages/python.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index aee97cb..b765a74 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3894,6 +3894,37 @@ simple and Pythonic domain language.")
        `(("python2-setuptools" ,python2-setuptools)
          ,@(package-native-inputs base))))))
 
+(define-public python-furl
+  (package
+    (name "python-furl")
+    (version "0.5.6")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "furl" version))
+        (sha256
+          (base32
+            "0lzpfpm686hvz3sr1mcrnd1b3lgmnw8v59gb43wfi98r3b671pqc"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-six" ,python-six)
+       ("python-orderedmultidict" ,python-orderedmultidict)))
+    (native-inputs
+     `(("python-pycodestyle" ,python-pycodestyle)))
+    (home-page "https://github.com/gruns/furl")
+    (synopsis "URL manipulation in Python")
+    (description "This package provides simple URL manipulation in Python.")
+    (license license:unlicense)
+    (properties `((python2-variant . ,(delay python2-furl))))))
+
+(define-public python2-furl
+  (let ((base (package-with-python2 (strip-python2-variant
+                                     python-furl))))
+    (package (inherit base)
+      (native-inputs
+       `(("python2-setuptools" ,python2-setuptools)
+         ,@(package-native-inputs base))))))
+
 (define-public python-sqlalchemy-utils
   (package
     (name "python-sqlalchemy-utils")

Re: [PATCH 4/6] gnu: Add python-furl.

[Hartmut Goebel]

Am 03.11.2016 um 11:56 schrieb Danny Milosavljevic:
> +    (description "This package provides simple URL manipulation in Python.")

Again, I'd prefer some text like on the homepage:

    Python's standard urllib and urlparse modules provide a number of
    URL manipulation functions, but using these functions to perform
    common URL manipulations proves tedious. Furl makes manipulating
    URLs easy.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

[PATCH 5/6] gnu: Add python-flask-babel.

[Danny Milosavljevic]

* gnu/packages/python.scm (python-flask-babel, python2-flask-babel): New variables.
---
 gnu/packages/python.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index b765a74..21adce7 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3925,6 +3925,37 @@ simple and Pythonic domain language.")
        `(("python2-setuptools" ,python2-setuptools)
          ,@(package-native-inputs base))))))
 
+(define-public python-flask-babel
+  (package
+    (name "python-flask-babel")
+    (version "0.11.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "Flask-Babel" version))
+        (sha256
+          (base32
+            "16b80cipdba9xj3jlaiaq6wgrgpjb70w3j01jjy9hbp4k71kd6yj"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-flask" ,python-flask)
+       ("python-babel" ,python-babel)
+       ("python-jinja2" ,python-jinja2)
+       ("python-pytz" ,python-pytz)))
+    (home-page "http://github.com/python-babel/flask-babel")
+    (synopsis "Adds i18n/l10n support to Flask applications")
+    (description "This package enables i18n/l10n support for Flask applications.")
+    (license license:bsd-3)
+    (properties `((python2-variant . ,(delay python2-flask-babel))))))
+
+(define-public python2-flask-babel
+  (let ((base (package-with-python2 (strip-python2-variant
+                                     python-flask-babel))))
+    (package (inherit base)
+      (native-inputs
+       `(("python2-setuptools" ,python2-setuptools)
+         ,@(package-native-inputs base))))))
+
 (define-public python-sqlalchemy-utils
   (package
     (name "python-sqlalchemy-utils")

Re: [PATCH 5/6] gnu: Add python-flask-babel.

[Hartmut Goebel]

Am 03.11.2016 um 11:56 schrieb Danny Milosavljevic:
> +    (synopsis "Adds i18n/l10n support to Flask applications")

"i18n and l10n"

> +    (description "This package enables i18n/l10n support for Flask applications.")

Again i suggest being a bit more verbose like the text on the homepage:

    Implements i18n and l10n support for Flask. This is based on the
    Python babel module as well as pytz both of which are installed
    automatically for you if you install this library.

But I would write "internationalization" and "localization" in the
description since the abreviations are already used in the synopsis.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

[PATCH 6/6] gnu: Enable passlib, babel, cryptography, pyt, psycopg2, furl, flask-babel and pytest in python-sqlalchemy-utils

[Danny Milosavljevic]

* gnu/packages/python.scm (python-sqlalchemy-utils): Modified.
---
 gnu/packages/python.scm | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 21adce7..927926e 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3968,9 +3968,18 @@ simple and Pythonic domain language.")
          (base32
           "1zbmmh7n8m01ikizn2mj1mfwch26nsr1awv9mvskqry7av0mpy98"))))
     (build-system python-build-system)
-    (inputs
+    (propagated-inputs
      `(("python-six" ,python-six)
-       ("python-sqlalchemy" ,python-sqlalchemy)))
+       ("python-sqlalchemy" ,python-sqlalchemy)
+       ("python-passlib" ,python-passlib)
+       ("python-babel" ,python-babel)
+       ("python-cryptography" ,python-cryptography)
+       ("python-pytz" ,python-pytz)
+       ("python-psycopg2" ,python-psycopg2)
+       ("python-furl" ,python-furl)
+       ("python-flask-babel" ,python-flask-babel)))
+    (native-inputs
+     `(("python-pytest" ,python-pytest)))
     (home-page "https://github.com/kvesteri/sqlalchemy-utils")
     (synopsis "Various utility functions for SQLAlchemy")
     (description

Re: [PATCH 6/6] gnu: Enable passlib, babel, cryptography, pyt, psycopg2, furl, flask-babel and pytest in python-sqlalchemy-utils

[Hartmut Goebel]

The patch title is much to long and does not fit in a line.

I suggest:
gnu: python-sqlalchemy-utils: Add inputs for extra features.


Beside of this I'm not sure whether we should really add all these
inputs. If a developer or administrator needs them, they are easily
added: Each "extra" feature add a single package. No complex stuff here.
But alone babel adds 21 MB, cryptography another ca. 70 MB.

I'm in favor of *not* adding any of these additional inputs.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |