From mboxrd@z Thu Jan 1 00:00:00 1970 From: cmmarusich@gmail.com Subject: Follow-up: Add system roll-back and switch-generation commands Date: Tue, 1 Nov 2016 22:48:10 -0700 Message-ID: <20161102054815.11253-1-cmmarusich@gmail.com> References: <87d1ihscmr.fsf@gnu.org> Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1oPW-0007Ds-7U for guix-devel@gnu.org; Wed, 02 Nov 2016 01:48:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1oPV-0002Ir-E1 for guix-devel@gnu.org; Wed, 02 Nov 2016 01:48:30 -0400 Received: from mail-pf0-x234.google.com ([2607:f8b0:400e:c00::234]:33881) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c1oPV-0002IY-8S for guix-devel@gnu.org; Wed, 02 Nov 2016 01:48:29 -0400 Received: by mail-pf0-x234.google.com with SMTP id n85so5340243pfi.1 for ; Tue, 01 Nov 2016 22:48:29 -0700 (PDT) Received: from garuda.hsd1.wa.comcast.net. ([2601:602:9d02:4725:4e0f:6eff:fef6:70b9]) by smtp.gmail.com with ESMTPSA id u1sm950957pfb.96.2016.11.01.22.48.27 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Nov 2016 22:48:27 -0700 (PDT) In-Reply-To: <87d1ihscmr.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org This patch series builds on 1ef8b72a7f87afe7cffe52393d99e1b14e4770e1 to add two new 'guix system' actions: roll-back and switch-generation. I've verified that both 'make check' and 'make check-system' pass (with the exception of the system tests 'nss-mdns' and 'encrypted-root-os', which both fail on my system even without my patches). I've manually verified the following for a VM with a single disk and single partition, as well as for a VM with multiple disks and the store on a separate partition: * The grub.cfg file that 'roll-back' and 'switch-generation' generates looks correct and is correctly registered as a GC root. * The system can boot after 'roll-back' and 'switch-generation', the default entry is correct, and the resources necessary for the GRUB theme are loaded without error. * Any attempt to switch to a nonexistent generation fail, regardless of whether a relative or absolute generation spec is used. * The existing 'list-generations' command continues to show the generations correctly, even after switching generations. Hopefully everything is OK this time! Thank you for taking the time to review it. -- Chris