From: cmmarusich@gmail.com
To: guix-devel@gnu.org
Subject: Follow-up: Add system roll-back and switch-generation commands
Date: Tue, 1 Nov 2016 22:48:10 -0700 [thread overview]
Message-ID: <20161102054815.11253-1-cmmarusich@gmail.com> (raw)
In-Reply-To: <87d1ihscmr.fsf@gnu.org>
This patch series builds on 1ef8b72a7f87afe7cffe52393d99e1b14e4770e1 to add
two new 'guix system' actions: roll-back and switch-generation.
I've verified that both 'make check' and 'make check-system' pass (with the
exception of the system tests 'nss-mdns' and 'encrypted-root-os', which both
fail on my system even without my patches). I've manually verified the
following for a VM with a single disk and single partition, as well as for a
VM with multiple disks and the store on a separate partition:
* The grub.cfg file that 'roll-back' and 'switch-generation' generates looks
correct and is correctly registered as a GC root.
* The system can boot after 'roll-back' and 'switch-generation', the default
entry is correct, and the resources necessary for the GRUB theme are loaded
without error.
* Any attempt to switch to a nonexistent generation fail, regardless
of whether a relative or absolute generation spec is used.
* The existing 'list-generations' command continues to show the
generations correctly, even after switching generations.
Hopefully everything is OK this time! Thank you for taking the time to review
it.
--
Chris
next prev parent reply other threads:[~2016-11-02 5:48 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 10:07 Add system roll-back and switch-generation commands cmmarusich
2016-10-28 10:07 ` [PATCH 01/10] * gnu/system.scm (<boot-parameters>): Add 'store-device' and 'store-fs-mount-point' cmmarusich
2016-10-30 0:12 ` Ludovic Courtès
2016-10-30 9:41 ` Chris Marusich
2016-10-30 22:19 ` Ludovic Courtès
2016-11-02 5:48 ` cmmarusich [this message]
2016-11-02 5:48 ` [PATCH 1/5] profiles: Extract a procedure for getting relative generation numbers cmmarusich
2016-11-06 16:56 ` Ludovic Courtès
2016-11-02 5:48 ` [PATCH 2/5] system: Rename previous-grub-entries to profile-grub-entries cmmarusich
2016-11-06 16:56 ` Ludovic Courtès
2016-11-02 5:48 ` [PATCH 3/5] system: Optionally limit the entries returned by profile-grub-entries cmmarusich
2016-11-06 16:57 ` Ludovic Courtès
2016-11-02 5:48 ` [PATCH 4/5] install: Extract procedure: install-grub-config cmmarusich
2016-11-06 16:59 ` Ludovic Courtès
2016-11-06 21:00 ` Danny Milosavljevic
2016-11-07 1:25 ` Chris Marusich
2016-11-07 10:32 ` Danny Milosavljevic
2016-11-02 5:48 ` [PATCH 5/5] system: Add 'guix system' actions: switch-generation and roll-back cmmarusich
2016-11-03 4:51 ` One more patch: doc: Add details to the 'guix system switch-generation' section Chris Marusich
2016-11-06 17:13 ` [PATCH 5/5] system: Add 'guix system' actions: switch-generation and roll-back Ludovic Courtès
2016-11-07 3:17 ` Chris Marusich
2016-11-03 0:19 ` [PATCH 01/10] * gnu/system.scm (<boot-parameters>): Add 'store-device' and 'store-fs-mount-point' Leo Famulari
2016-11-03 4:36 ` Chris Marusich
2016-11-03 10:35 ` Chris Marusich
2016-11-03 22:34 ` Danny Milosavljevic
2016-11-04 3:34 ` Chris Marusich
2016-11-04 3:55 ` Chris Marusich
2016-11-03 13:10 ` Fix a boot problem reported by ng0 cmmarusich
2016-11-03 13:10 ` [PATCH] system: Avoid using device paths in <menu-entry> device field cmmarusich
2016-11-04 15:49 ` Leo Famulari
2016-11-06 16:51 ` Ludovic Courtès
2016-10-28 10:07 ` [PATCH 02/10] Add 'device' field to <menu-entry> cmmarusich
2016-10-28 10:07 ` [PATCH 03/10] Refactor grub.cfg generation logic cmmarusich
2016-10-28 10:07 ` [PATCH 04/10] Extract procedure: relative-generation-spec->number cmmarusich
2016-10-28 10:07 ` [PATCH 05/10] Rename previous-grub-entries to grub-entries cmmarusich
2016-10-28 10:07 ` [PATCH 06/10] grub-entries: take a list of numbers on input cmmarusich
2016-10-28 10:07 ` [PATCH 07/10] Factor out procedure: install-grub-config cmmarusich
2016-10-28 10:07 ` [PATCH 08/10] Implement switch-generation and roll-back cmmarusich
2016-10-28 10:07 ` [PATCH 09/10] Rename grub-entries to profile-grub-entries cmmarusich
2016-10-28 10:07 ` [PATCH 10/10] Mention new 'guix system' features in the manual cmmarusich
2016-10-29 21:13 ` Add system roll-back and switch-generation commands Ludovic Courtès
2016-10-29 21:22 ` Chris Marusich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102054815.11253-1-cmmarusich@gmail.com \
--to=cmmarusich@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.