From: Leo Famulari <leo@famulari.name>
To: Theodoros Foradis <theodoros.for@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH v3 3/3] gnu: Add kicad.
Date: Sat, 29 Oct 2016 20:18:38 -0400 [thread overview]
Message-ID: <20161030001838.GB15871@jasmine> (raw)
In-Reply-To: <20161025170001.2717-4-theodoros.for@openmailbox.org>
On Tue, Oct 25, 2016 at 08:00:01PM +0300, Theodoros Foradis wrote:
> * gnu/packages/engineering.scm (kicad): New variable.
Looks pretty good to me. Below are some things I would investigate and
potentially fix on my own before pushing to Savannah; no need to send a
new patch.
Now we are just waiting to learn more about python2-wxpython...
> +;; We use kicad from a git commit, because support for boost 1.61.0
> +;; has been recently added.
> +(define-public kicad
> + (let ((commit "4ee344e150bfaf3a6f3f7bf935fb96ae07c423fa")
> + (revision "1"))
> + (package
> + (name "kicad")
> + (version (string-append "4.0-" revision "."
> + (string-take commit 7)))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://git.launchpad.net/kicad.git")
Please use the correct URL here :)
> + #:configure-flags
> + (list "-DKICAD_STABLE_VERSION=ON"
> + "-DKICAD_REPO_NAME=stable"
> + "-DKICAD_BUILD_VERSION=4.0"
If possible, we should use our package's version string here. We aren't
really packaging KiCad 4.0, but rather 4.0 plus some extra Git commits,
right?
> + "-DCMAKE_BUILD_TYPE=Release"
> + "-DKICAD_SKIP_BOOST=ON"; Use our system's boost library
> + "-DKICAD_SCRIPTING=ON"
> + "-DKICAD_SCRIPTING_MODULES=ON"
> + "-DKICAD_SCRIPTING_WXPYTHON=ON"
> + ;; Has to be set explicitely, as we don't have the wxPython
> + ;; headers in the wxwidgets store item, but in wxPython.
> + (string-append "-DCMAKE_CXX_FLAGS=-I"
> + (assoc-ref %build-inputs "wxpython")
> + "/include/wx-3.0")
> + "-DCMAKE_BUILD_WITH_INSTALL_RPATH=TRUE"
> + "-DBUILD_GITHUB_PLUGIN=OFF")
I would try building with this on. Does it require some unpackaged
dependencies?
next prev parent reply other threads:[~2016-10-30 0:18 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 21:16 [PATCH 0/3] gnu: Add kicad Theodoros Foradis
2016-10-24 21:16 ` [PATCH 1/3] gnu: Add wxwidgets-gtk2 Theodoros Foradis
2016-10-24 21:16 ` [PATCH 2/3] gnu: Add python2-wxpython Theodoros Foradis
2016-10-25 8:32 ` Hartmut Goebel
2016-10-25 9:58 ` Theodoros Foradis
2016-10-25 16:20 ` Efraim Flashner
2016-10-24 21:16 ` [PATCH 3/3] gnu: Add kicad Theodoros Foradis
2016-10-25 0:36 ` Leo Famulari
2016-10-25 0:41 ` Leo Famulari
2016-10-25 8:11 ` Theodoros Foradis
2016-10-25 12:48 ` Leo Famulari
2016-10-25 16:09 ` [PATCH v2 0/3] " Theodoros Foradis
2016-10-25 16:09 ` [PATCH v2 1/3] gnu: Add python2-wxpython Theodoros Foradis
2016-10-25 16:32 ` Leo Famulari
2016-10-25 16:09 ` [PATCH v2 2/3] gnu: Add kicad Theodoros Foradis
2016-10-25 16:09 ` [PATCH v2 3/3] gnu: Add python2-wxpython Theodoros Foradis
2016-10-25 16:35 ` Leo Famulari
2016-10-25 17:13 ` Theodoros Foradis
2016-10-30 0:13 ` Leo Famulari
2016-10-30 10:13 ` Hartmut Goebel
2016-10-31 10:42 ` Danny Milosavljevic
2016-10-31 15:38 ` Danny Milosavljevic
2016-10-25 18:05 ` Theodoros Foradis
2016-10-25 18:28 ` Leo Famulari
2016-10-25 16:59 ` [PATCH v3 0/3] gnu: Add kicad Theodoros Foradis
2016-10-25 16:59 ` [PATCH v3 1/3] gnu: Add wxwidgets-gtk2 Theodoros Foradis
2016-11-02 8:15 ` Danny Milosavljevic
2016-10-25 17:00 ` [PATCH v3 2/2] gnu: Add python2-wxpython Theodoros Foradis
2016-11-02 7:57 ` Danny Milosavljevic
2016-11-02 13:53 ` Theodoros Foradis
2016-10-25 17:00 ` [PATCH v3 3/3] gnu: Add kicad Theodoros Foradis
2016-10-30 0:18 ` Leo Famulari [this message]
2016-11-02 15:42 ` Theodoros Foradis
2016-11-05 18:41 ` Leo Famulari
2016-11-07 18:16 ` [PATCH v4 1/3] gnu: Add wxwidgets-gtk2 Theodoros Foradis
2016-11-07 18:16 ` [PATCH v4 2/3] gnu: Add python2-wxpython Theodoros Foradis
2016-11-07 22:38 ` Danny Milosavljevic
2016-11-07 18:16 ` [PATCH v4 3/3] gnu: Add kicad Theodoros Foradis
2016-11-07 18:47 ` Efraim Flashner
2016-11-15 20:53 ` [PATCH v5 1/4] gnu: Add wxwidgets-gtk2 Theodoros Foradis
2016-11-15 20:53 ` [PATCH v5 2/4] gnu: Add python2-wxpython Theodoros Foradis
2016-11-15 20:53 ` [PATCH v5 3/4] gnu: Add kicad Theodoros Foradis
2016-11-15 20:53 ` [PATCH v5 4/4] gnu: Add kicad-library Theodoros Foradis
2016-11-15 19:26 ` [PATCH v4 3/3] gnu: Add kicad Leo Famulari
2016-11-22 19:46 ` Theodoros Foradis
2016-11-25 5:40 ` Leo Famulari
2016-11-07 21:04 ` [PATCH v3 " Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161030001838.GB15871@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=theodoros.for@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.