From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH v2 3/3] gnu: Add python2-wxpython. Date: Sat, 29 Oct 2016 20:13:20 -0400 Message-ID: <20161030001320.GA15871@jasmine> References: <20161025124841.GA887@jasmine> <20161025160907.30181-1-theodoros.for@openmailbox.org> <20161025160907.30181-4-theodoros.for@openmailbox.org> <20161025163524.GB3404@jasmine> <87oa28tkq4.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0dkc-0003X4-RV for guix-devel@gnu.org; Sat, 29 Oct 2016 20:13:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c0dkZ-0006e0-J5 for guix-devel@gnu.org; Sat, 29 Oct 2016 20:13:26 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:33366) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c0dkZ-0006dr-Eh for guix-devel@gnu.org; Sat, 29 Oct 2016 20:13:23 -0400 Content-Disposition: inline In-Reply-To: <87oa28tkq4.fsf@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Theodoros Foradis Cc: guix-devel On Tue, Oct 25, 2016 at 08:13:55PM +0300, Theodoros Foradis wrote: > Leo Famulari writes: > >> + (native-inputs > >> + `(("gtk+" ,gtk+-2) > >> + ("expat" ,expat) > >> + ("libjpeg" ,libjpeg) > >> + ("libpng" ,libpng) > >> + ("libtiff" ,libtiff) > >> + ("libsm" ,libsm) > >> + ("libx11" ,libx11) > >> + ("mesa" ,mesa) > >> + ("pkg-config" ,pkg-config) > >> + ("python2-setuptools" ,python2-setuptools) > >> + ("zlib" ,zlib))) > > > > To clarify, all these native-inputs are only used while building? > > Native inputs typically are not intended to be available once the > > package has been built and installed. > > To quote Danny Milosavljevic, whose original patch of python2-wxpython I > modified: > > I added gtk, opengl etc as native inputs instead of regular inputs > > because from the point of view of Python they are not direct inputs. I'm not sure what that means in this case. > I guess this applies to gtk+,opengl,mesa and expat(?) (the others are > intented to be native-inputs for sure). I am unsure if they are intended > to be available at runtime. I assumed they were not, based on the > previous comment. If they, they should be moved to inputs. I checked the references of the built package like this: $ guix gc --references $(./pre-inst-env guix build python2-wxpython) /gnu/store/1xfc2pwr7qfjib9kfy3n2hjq56z7jyjx-python-2.7.11 /gnu/store/6njycb0nzbczqbzvcyn1vw5sg7xsaanr-python2-setuptools-18.3.1 /gnu/store/9nifwk709wajpyfwa0jzaa3p6mf10vxs-gcc-4.9.3-lib /gnu/store/a5xcl27fflh6ppysf5wrsfnn3ly2gyhy-python2-wxpython-3.0.2.0 /gnu/store/fdlind5y49q37m1g1wsvx840q2scrp6x-wxwidgets-gtk2-3.0.2 /gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23 /gnu/store/ykzwykkvr2c80rw4l1qh3mvfdkl7jibi-bash-4.3.42 As you can see, many of the package's inputs not referred to by the built package. This means that those inputs will by deleted by the next `guix gc` (unless some other installed package refers to them). That's fine for native-inputs, which are supposed to be used only while building. As for whether or not the packages are required at run-time, I don't know. wxPython's documentation should explain what the software does and what libraries it wants to use. Hartmut, assuming that wxPython needs these packages at run-time, do you have any recommendations for how to keep references to them? I ask based on your recent work on Python packaging. Otherwise this package looks good, minus some minor cosmetic nits.