From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 07/68] gnu: bluez-qt: Update to 5.27.0.
Date: Sat, 29 Oct 2016 16:33:37 -0400
Message-ID: <20161029203337.GB32311@jasmine>
References: <20161029180519.6061-1-david@craven.ch>
	<20161029180519.6061-7-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57057)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1c0aK1-0006nm-Rr
	for guix-devel@gnu.org; Sat, 29 Oct 2016 16:33:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1c0aJy-00089w-NH
	for guix-devel@gnu.org; Sat, 29 Oct 2016 16:33:45 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:42037)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <leo@famulari.name>) id 1c0aJy-00089j-KS
	for guix-devel@gnu.org; Sat, 29 Oct 2016 16:33:42 -0400
Content-Disposition: inline
In-Reply-To: <20161029180519.6061-7-david@craven.ch>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

On Sat, Oct 29, 2016 at 08:04:18PM +0200, David Craven wrote:
> * gnu/packages/kde-frameworks.scm (bluez-qt): Update to 5.27.0 and
>   fix indentation.

In general, when making many changes that have no effect (for example,
several dozen indentation fixes), I think they should be done
separately.

A purely cosmetic commit can be easily audited by rebuilding the package
after the commit. If only indentation was changed, no rebuild will be
required.

By combining the "real" and cosmetic changes, the burden on reviewers is
increased significantly. Now, we have to manually compare the
re-indented code to verify that nothing changed.

Something to keep in mind in the future...