From: Leo Famulari <leo@famulari.name>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 07/68] gnu: bluez-qt: Update to 5.27.0.
Date: Sat, 29 Oct 2016 16:33:37 -0400 [thread overview]
Message-ID: <20161029203337.GB32311@jasmine> (raw)
In-Reply-To: <20161029180519.6061-7-david@craven.ch>
On Sat, Oct 29, 2016 at 08:04:18PM +0200, David Craven wrote:
> * gnu/packages/kde-frameworks.scm (bluez-qt): Update to 5.27.0 and
> fix indentation.
In general, when making many changes that have no effect (for example,
several dozen indentation fixes), I think they should be done
separately.
A purely cosmetic commit can be easily audited by rebuilding the package
after the commit. If only indentation was changed, no rebuild will be
required.
By combining the "real" and cosmetic changes, the burden on reviewers is
increased significantly. Now, we have to manually compare the
re-indented code to verify that nothing changed.
Something to keep in mind in the future...
next prev parent reply other threads:[~2016-10-29 20:33 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 18:04 [PATCH 01/68] gnu: Add flex-2.6.1 David Craven
2016-10-29 18:04 ` [PATCH 02/68] gnu: extra-cmake-modules: Update to 5.27.0 David Craven
2016-10-29 21:27 ` Ricardo Wurmus
2016-10-29 18:04 ` [PATCH 03/68] gnu: gpgmepp: Update to 16.08.2 David Craven
2016-10-29 18:04 ` [PATCH 04/68] gnu: kpmcore: Fix indentation David Craven
2016-10-29 18:04 ` [PATCH 05/68] gnu: phonon: " David Craven
2016-10-29 18:04 ` [PATCH 06/68] gnu: attica: Update to 5.27.0 David Craven
2016-10-29 18:04 ` [PATCH 07/68] gnu: bluez-qt: " David Craven
2016-10-29 20:33 ` Leo Famulari [this message]
2016-10-29 20:42 ` Leo Famulari
2016-10-29 18:04 ` [PATCH 08/68] gnu: breeze-icons: " David Craven
2016-10-29 18:04 ` [PATCH 09/68] gnu: kapidox: " David Craven
2016-10-29 18:04 ` [PATCH 10/68] gnu: karchive: " David Craven
2016-10-29 18:04 ` [PATCH 11/68] gnu: kcodecs: " David Craven
2016-10-29 18:04 ` [PATCH 12/68] gnu: kconfig: " David Craven
2016-10-29 18:04 ` [PATCH 13/68] gnu: kcoreaddons: " David Craven
2016-10-29 18:04 ` [PATCH 14/68] gnu: kdbusaddons: " David Craven
2016-10-29 18:04 ` [PATCH 15/68] gnu: kdnssd: " David Craven
2016-10-29 18:04 ` [PATCH 16/68] gnu: kguiaddons: " David Craven
2016-10-29 18:04 ` [PATCH 17/68] gnu: ki18n: " David Craven
2016-10-29 18:04 ` [PATCH 18/68] gnu: kidletime: " David Craven
2016-10-29 18:04 ` [PATCH 19/68] gnu: kitemmodels: " David Craven
2016-10-29 18:04 ` [PATCH 20/68] gnu: kitemviews: " David Craven
2016-10-29 18:04 ` [PATCH 21/68] gnu: kplotting: " David Craven
2016-10-29 18:04 ` [PATCH 22/68] gnu: kwayland: " David Craven
2016-10-29 18:04 ` [PATCH 23/68] gnu: kwidgetsaddons: " David Craven
2016-10-29 18:04 ` [PATCH 24/68] gnu: kwindowsystem: " David Craven
2016-10-29 18:04 ` [PATCH 25/68] gnu: modemmanager-qt: " David Craven
2016-10-29 18:04 ` [PATCH 26/68] gnu: networkmanager-qt: " David Craven
2016-10-29 18:04 ` [PATCH 27/68] gnu: oxygen-icons: " David Craven
2016-10-29 18:04 ` [PATCH 28/68] gnu: solid: " David Craven
2016-10-29 20:28 ` Leo Famulari
2016-10-29 18:04 ` [PATCH 29/68] gnu: sonnet: " David Craven
2016-10-29 18:04 ` [PATCH 30/68] gnu: threadweaver: " David Craven
2016-10-29 18:04 ` [PATCH 31/68] gnu: kauth: " David Craven
2016-10-29 18:04 ` [PATCH 32/68] gnu: kcompletion: " David Craven
2016-10-29 18:04 ` [PATCH 33/68] gnu: kcrash: " David Craven
2016-10-29 18:04 ` [PATCH 34/68] gnu: kdoctools: " David Craven
2016-10-29 18:04 ` [PATCH 35/68] gnu: kfilemetadata: " David Craven
2016-10-29 18:04 ` [PATCH 36/68] gnu: kimageformats: " David Craven
2016-10-29 18:04 ` [PATCH 37/68] gnu: kjobwidgets: " David Craven
2016-10-29 18:04 ` [PATCH 38/68] gnu: knotifications: " David Craven
2016-10-29 18:04 ` [PATCH 39/68] gnu: kpackage: " David Craven
2016-10-29 18:04 ` [PATCH 40/68] gnu: kpty: " David Craven
2016-10-29 18:04 ` [PATCH 41/68] gnu: kunitconversion: " David Craven
2016-10-29 18:04 ` [PATCH 42/68] gnu: baloo: " David Craven
2016-10-29 18:04 ` [PATCH 43/68] gnu: kactivities: " David Craven
2016-10-29 18:04 ` [PATCH 44/68] gnu: kactivities-stats: " David Craven
2016-10-29 18:04 ` [PATCH 45/68] gnu: kbookmarks: " David Craven
2016-10-29 18:04 ` [PATCH 46/68] gnu: kcmutils: " David Craven
2016-10-29 18:04 ` [PATCH 47/68] gnu: kconfigwidgets: " David Craven
2016-10-29 18:04 ` [PATCH 48/68] gnu: kdeclarative: " David Craven
2016-10-29 18:05 ` [PATCH 49/68] gnu: kded: " David Craven
2016-10-29 18:05 ` [PATCH 50/68] gnu: kdesignerplugin: " David Craven
2016-10-29 18:05 ` [PATCH 51/68] gnu: kdesu: " David Craven
2016-10-29 18:05 ` [PATCH 52/68] gnu: kemoticons: " David Craven
2016-10-29 18:05 ` [PATCH 53/68] gnu: kglobalaccel: " David Craven
2016-10-29 18:05 ` [PATCH 54/68] gnu: kiconthemes: " David Craven
2016-10-29 18:05 ` [PATCH 55/68] gnu: kinit: " David Craven
2016-10-29 18:05 ` [PATCH 56/68] gnu: kio: " David Craven
2016-10-29 18:05 ` [PATCH 57/68] gnu: knewstuff: " David Craven
2016-10-29 18:05 ` [PATCH 58/68] gnu: knotifyconfig: " David Craven
2016-10-29 18:05 ` [PATCH 59/68] gnu: kparts: " David Craven
2016-10-29 18:05 ` [PATCH 60/68] gnu: kpeople: " David Craven
2016-10-29 18:05 ` [PATCH 61/68] gnu: krunner: " David Craven
2016-10-29 18:05 ` [PATCH 62/68] gnu: kservice: " David Craven
2016-10-29 18:05 ` [PATCH 63/68] gnu: ktexteditor: " David Craven
2016-10-29 18:05 ` [PATCH 64/68] gnu: ktextwidgets: " David Craven
2016-10-29 18:05 ` [PATCH 65/68] gnu: kwallet: " David Craven
2016-10-29 18:05 ` [PATCH 66/68] gnu: kxmlgui: " David Craven
2016-10-29 18:05 ` [PATCH 67/68] gnu: kxmlrpcclient: " David Craven
2016-10-29 18:05 ` [PATCH 68/68] gnu: plasma-framework: " David Craven
2016-10-29 18:46 ` [PATCH 01/68] gnu: Add flex-2.6.1 Marius Bakke
2016-10-29 20:27 ` Leo Famulari
2016-10-29 20:40 ` Leo Famulari
2016-10-29 20:45 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161029203337.GB32311@jasmine \
--to=leo@famulari.name \
--cc=david@craven.ch \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.