From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH] gnu: Add plantuml. Date: Thu, 27 Oct 2016 13:13:30 +0300 Message-ID: <20161027101329.GD18185@macbook42.flashner.co.il> References: <20161024131225.24436-1-theodoros.for@openmailbox.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="J4XPiPrVK1ev6Sgr" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzhgp-0007Jj-8l for guix-devel@gnu.org; Thu, 27 Oct 2016 06:13:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzhgk-0002Hx-AA for guix-devel@gnu.org; Thu, 27 Oct 2016 06:13:39 -0400 Received: from flashner.co.il ([178.62.234.194]:36231) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzhgj-0002H0-Ta for guix-devel@gnu.org; Thu, 27 Oct 2016 06:13:34 -0400 Content-Disposition: inline In-Reply-To: <20161024131225.24436-1-theodoros.for@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Theodoros Foradis Cc: guix-devel@gnu.org --J4XPiPrVK1ev6Sgr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I don't java, so I haven't tried it out, so my comments are mostly cosmetic on the package definition. On Mon, Oct 24, 2016 at 04:12:25PM +0300, Theodoros Foradis wrote: > + > +(define-public plantuml > + (package > + (name "plantuml") > + (version "8048") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "https://downloads.sourceforge.net/project/plantuml/= plantuml-" > + version ".tar.gz")) this should be of the mirror://sourceforge type > + (sha256 > + (base32 > + "1vipxd6p7isb1k1qqh4hrpfcj27hx1nll2yp0rfwpvps1w2d936i"))= )) > + (build-system ant-build-system) > + (arguments > + `(#:tests? #f ; no tests > + #:build-target "dist" > + #:phases > + (modify-phases %standard-phases > + (add-before 'build 'delete-extra-from-cp > + (lambda _ > + (substitute* "build.xml" > + (("1.6") "1.7")) > + (substitute* "build.xml" > + ((" + (substitute* "build.xml" > + (("j2v8_macosx_x86_64-3.1.7.jar\" />") "-->")))) return #t also, since they're all for the same set (build.xml), you can take out the duplicate substitute* lines > + (add-before 'install 'gen-install > + (lambda* (#:key outputs #:allow-other-keys) > + (mkdir-p "build/jar") > + (system* "mv" "plantuml.jar" "build/jar") > + ((@@ (guix build ant-build-system) default-build.xml) > + "plantuml.jar" > + (string-append (assoc-ref outputs "out") > + "/share/java")))) > + (add-after 'install 'make-wrapper > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (wrapper (string-append out "/bin/plantuml"= ))) > + (mkdir-p (string-append out "/bin")) > + (with-output-to-file wrapper > + (lambda _ > + (display > + (string-append > + "#!" (assoc-ref inputs "bash") "/bin/sh\n\= n" > + (assoc-ref inputs "jre") "/bin/java -jar " > + out "/share/java/plantuml.jar \"$@\"\n")))) > + (chmod wrapper #o555))))))) > + (inputs > + `(("graphviz" ,graphviz) > + ("bash" ,bash) > + ("jre" ,icedtea "out"))) > + (home-page "http://plantuml.com/") > + (synopsis "Draw UML diagrams from simple textual description") > + (description > + "Plantuml is a tool to generate sequence, usecase, class, activity, > +component, state, deployment and object UML diagrams, using a simple and > +human readable text description. Contains salt, a tool that can design = simple > +graphical interfaces.") > + (license license:gpl3+))) > --=20 > 2.10.1 >=20 >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --J4XPiPrVK1ev6Sgr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJYEdM+AAoJEPTB05F+rO6TElUQAKFtupTCOzNXmkTwk6NpkQ40 IQ/pX1mBGp9N0C/BPAVp7BaIQMo7bHhcujK/6i5faOFANFjPE85bMWmFVYKyNI+N FMNzvsvQIX90r98/mxmanGGTqvrMRqxMJK3+J666reUuAcXZGxKlNOOxVehi7KR9 OYqHQYco0IpnhfA0Opy+VW92pLYx0I0mH7LTL/qz1+4BdB7jW8EA+49iO3JaK9M9 7l8llsH1Hjpf6tW6fT4THL0SLG4bYjq9AN4Iwa+f5OdAgqvme4eX/SXK6i8tB4nr nl8Q3fgCY24ppjRN82zVdd5XJ22ax7MALVELyQYskmh6TDLtALUfgbcwhkYhN3U3 RHW4vlQiPkqpJEsVorl01SHHU3Vek0y0ZC3yZ44vAqyEh6FBbEozarTsHQd17Bg8 KxgSPynPgD5Kme9hlnDnVyleA1M038Cr3ZOeF265mOsn3vxOsXp9/XGwQY/7cBTf IPj9GuYt5pDbW7kBIJkLISMlHN9hHxcAwVYkERKmITpc1HJoyzsU0sLjZylyhR3G tBkhlT4r+jPP9DATp3zC/QI5obVXOOJOXcI6H4IWlczrziMmzmzTAUvxNtITm+xZ hwMxZEgdeyRH7kjbN7LF0VjJZP3rYy3QbbPIP10LVa6kK5KOIlbLqRIBEJnVMJ/U UH78JpN+4hkZB/h6W/G9 =pt0y -----END PGP SIGNATURE----- --J4XPiPrVK1ev6Sgr--