From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add libjxr. Date: Sun, 23 Oct 2016 17:29:29 -0400 Message-ID: <20161023212929.GB6318@jasmine> References: <87eg39qvjh.fsf@openmailbox.org> <20161021235859.GA9570@jasmine> <87a8dwrdf5.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byQKk-00045G-13 for guix-devel@gnu.org; Sun, 23 Oct 2016 17:29:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byQKg-0002bM-Pd for guix-devel@gnu.org; Sun, 23 Oct 2016 17:29:33 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:54394) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1byQKg-0002bI-Ls for guix-devel@gnu.org; Sun, 23 Oct 2016 17:29:30 -0400 Content-Disposition: inline In-Reply-To: <87a8dwrdf5.fsf@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Kei Kebreau Cc: guix-devel@gnu.org --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 22, 2016 at 04:33:18AM -0400, Kei Kebreau wrote: > The URL for the upstream site's tarball is > http://download-codeplex.sec.s-msft.com/Download/Release?ProjectName=3Djx= rlib&DownloadId=3D685250&FileTime=3D130142428056630000&Build=3D21031. >=20 > Is something like that acceptable in Guix code? I know it works with > wget, but I was hesitant to use it as the source URL. Now that's an ugly URL! But, I still think we should download the source code from the upstream site rather than from Debian, whenever possible. > >> diff --git a/gnu/packages/patches/libjxr-fix-typos.patch > >> b/gnu/packages/patches/libjxr-fix-typos.patch > >> new file mode 100644 > >> index 0000000..3c051dd > >> --- /dev/null > >> +++ b/gnu/packages/patches/libjxr-fix-typos.patch > >> @@ -0,0 +1,60 @@ > >> +Description: Fix typos and remove some warnings > >> +Author: Mathieu Malaterre > > > > Can you include a link to the source of this patch? > > >=20 > This patch comes from Debian's set of patches for the sources. Could I > leave "This patch comes from Debian" with the link to it on the top, or > is more detail necessary? Ideally, patches include a link to their source and a brief explanation of why we need them. If we write the patch ourselves, then the author(s) should be named and they should also include an explanation. One way or another, we should report these bugs upstream. > >> diff --git a/gnu/packages/patches/libjxr-use-cmake.patch > >> b/gnu/packages/patches/libjxr-use-cmake.patch > >> new file mode 100644 > >> index 0000000..cb5919e > >> --- /dev/null > >> +++ b/gnu/packages/patches/libjxr-use-cmake.patch > >> @@ -0,0 +1,143 @@ > >> +Description: Prefer a cmake based build system > >> +Author: Mathieu Malaterre > >> +Forwarded: https://jxrlib.codeplex.com/discussions/440294 > > > > Why doesn't upstream's build system work? >=20 > Upstream's build system simply doesn't have configuration or > installation targets in the provided Makefile. Using the cmake patch > makes the definition cleaner at the cost of relying on outside work > [1]. If this is not acceptable, I can see about writing manual > replacement phases to the best of my ability. >=20 > [1]: https://jxrlib.codeplex.com/discussions/440294 Hm, not an ideal situation. If Debian is using this patch, we should link to it's source on Debian's site instead of this message board. I don't know enough about CMake to judge the patch but I'd be more comfortable if Debian was using it. What do others think? --AhhlLboLdkugWU4S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYDSu5AAoJECZG+jC6yn8IluUQAKqXbaWhX6ejbf0bsvxB3x4m pk8Cx18Tg2Aqa/w+5ZISgb880buXIH1t/t/NWfn8+AEDJh4i/2yBldMVdv8IpXq6 Q+T78sMgEFQGoOLOifBsBSj7xrnEPl/i6diiIhjyC08UcVuRBPlU4JGPOnmmi9zs thujvHI/ug4Exl2Sw5L6kHD5eesvj0F4VSZf1LVWcEuE7tGnBXxKGdRxJ1M7H9zN 77+G/T+kThXUypHWDPchZ39+GSS8Tqsmhzh3u1P2oH4QoRj9t1YP0NC7ZkOrHlm/ eoW+EO9juEth8w9zjJuKB8vFZ/gy0Mp1Fj/UoBskmQUut2Oac93J6smX/fKyzVZc TcZuvIRrTVj6Ep6yjDOY2VepAA33GVYyH7F5aiXmPE4+laPK+qIdGZBCFc0HW54c 7skV1Vd8kTKZFfCVmrJEYrc0nINtUU76T4KTYp+UT7iqTw/asx5v9RBAAmTnO0lK Cs9Uz2tsKPeKH1Cv3dUF3weEahqkuRjkCyaSXkmiH4Ba0DtSmFirHBhEyXe64PfB Avgn33ZLWIwGrZ18prK7WRAclOSsTPBnDXStnG+Ys2AqBASrV22qP7pIDxvqWXe+ v8C4/tvSEqT3Zwq1rtrsHw/TsuvqX0DoZh3F4a0FGsp8BIqVZk+2W4EcElm5+vNO m0IMayp2ma7k6C//ekJ/ =4R5P -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S--