[PATCH] gnu: link-grammar: New module.

[PATCH] gnu: link-grammar: New module.

[Amirouche Boubekki]

[-- Attachment #1.1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #1.2: Type: text/html, Size: 26 bytes --]

[-- Attachment #2: 0001-gnu-link-grammar-New-module.patch --]
[-- Type: text/x-patch, Size: 3418 bytes --]

From 391889d22f102368cc44d6a0a928fccd20810269 Mon Sep 17 00:00:00 2001
From: Amirouche <amirouche@hypermove.net>
Date: Sun, 23 Oct 2016 16:46:12 +0200
Subject: [PATCH] gnu: link-grammar: New module

* gnu/packages/link-grammar.scm: New module.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add new file.
---
 gnu/local.mk                  |  1 +
 gnu/packages/link-grammar.scm | 52 +++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 53 insertions(+)
 create mode 100644 gnu/packages/link-grammar.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index eb8322e..31ad798 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -221,6 +221,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/libunwind.scm			\
   %D%/packages/libupnp.scm			\
   %D%/packages/lighting.scm                     \
+  %D%/packages/link-grammar.scm			\
   %D%/packages/links.scm			\
   %D%/packages/linux.scm			\
   %D%/packages/lirc.scm				\
diff --git a/gnu/packages/link-grammar.scm b/gnu/packages/link-grammar.scm
new file mode 100644
index 0000000..6d1b302
--- /dev/null
+++ b/gnu/packages/link-grammar.scm
@@ -0,0 +1,52 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 Amirouche Boubekki <amirouche@hypermove.net>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages link-grammar)
+  #:use-module (guix packages)
+  #:use-module (guix build-system gnu)
+  #:use-module ((guix licenses) #:select (lgpl2.1+))
+  #:use-module (guix download)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages databases)
+  #:use-module (gnu packages compression))  
+
+(define-public link-grammar
+  (package
+    (name "link-grammar")
+    (version "5.3.11")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append "http://www.abiword.org/downloads/link-grammar/"
+                                 version "/link-grammar-" version ".tar.gz"))
+             (sha256
+              (base32
+               "1mqc2zhq360k2xslsjw5x8nfmbsk55x03dvyhb7bzpf75vl3mjkk"))))
+    (build-system gnu-build-system)
+    (inputs `(("sqlite" ,sqlite)
+              ("zlib" ,zlib)))
+    (home-page "http://www.abisource.com/projects/link-grammar/")
+    (synopsis "Syntactic parser for several language")
+    (description
+     "Link Grammar is a syntactic parser of English, Russian, Arabic and
+Persian (and other languages as well), based on Link Grammar, an original
+theory of syntax and morphology.  Given a sentence, the system assigns to it a
+syntactic structure, which consists of a set of labelled links connecting
+pairs of words.  The parser also produces a \"constituent\" (HPSG style phrase
+tree) representation of a sentence (showing noun phrases, verb phrases,
+etc.). ")
+    (license lgpl2.1+)))
-- 
2.10.0

Re: [PATCH] gnu: link-grammar: New module.

[Catonano]

[-- Attachment #1: Type: text/plain, Size: 137 bytes --]

2016-10-23 16:54 GMT+02:00 Amirouche Boubekki <amirouche.boubekki@gmail.com>
:

>
>
just a typo: in the synopsys: "... several langageS"

[-- Attachment #2: Type: text/html, Size: 512 bytes --]

Re: [PATCH] gnu: link-grammar: New module.

[Leo Famulari]

On Sun, Oct 23, 2016 at 04:54:17PM +0200, Amirouche Boubekki wrote:
> From 391889d22f102368cc44d6a0a928fccd20810269 Mon Sep 17 00:00:00 2001
> From: Amirouche <amirouche@hypermove.net>
> Date: Sun, 23 Oct 2016 16:46:12 +0200
> Subject: [PATCH] gnu: link-grammar: New module
> 
> * gnu/packages/link-grammar.scm: New module.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add new file.

Thanks! This should go in (gnu packages language). I would have moved it
there myself if not for a different problem...

> +    (inputs `(("sqlite" ,sqlite)
> +              ("zlib" ,zlib)))

The built output of the package does not refer to sqlite or zlib:

$ guix gc --references $(./pre-inst-env guix build link-grammar)
/gnu/store/7njyh7586r6kk2lfbz2wg52n3la89zda-link-grammar-5.3.11
/gnu/store/9nifwk709wajpyfwa0jzaa3p6mf10vxs-gcc-4.9.3-lib
/gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23

This means that when the user eventually collects garbage with `guix
gc`, the sqlite and zlib libraries that link-grammar uses may be
deleted, breaking link-grammar.

If sqlite and zlib are only used when building, but not when running
link-grammar, then they should be native-inputs.

Otherwise, we will need to figure out how to make link-grammar retain
references to these libraries.

Re: [PATCH] gnu: link-grammar: New module.

[Amir P]

[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]

On Sun, 23 Oct 2016 17:20:11 -0400 Leo Famulari wrote:
> If sqlite and zlib are only used when building, but not when running
> link-grammar, then they should be native-inputs.
>
> Otherwise, we will need to figure out how to make link-grammar retain
> references to these libraries.

The link-grammar library doesn't use the zlib library directly or
indirectly.
What happens is that zlib.h is needed for the compilation of its sat-solver
code
because it is included in a header file of the minisat library which is
indirectly
included by the sat-solver code. So zlib (actually zlib.h) is only used
when building.

However, if the sqlite library+headers exist when using "configure",
HAVE_SQLITE will get defined, which will bring in code that can use sqlite
(sqlite3_open etc. are referenced in the result link-grammar library).
As this code is currently not fully functional, a solution may be to
"configure"
link-grammar without the presence of the sqlite library+headers.
A better solution may be to add a link-grammar "configure" option like
"--enable-sqlite".
If you think it is indeed better, I will open an issue there for adding it
- to be
included in the next version - 5.3.12.
In any case, 5.3.12 is needed to overcome additional problems in 5.3.11
(some
of them are already fixed in the repository, and for some others
pull-requests are
still pending).

[-- Attachment #2: Type: text/html, Size: 2413 bytes --]

Re: [PATCH] gnu: link-grammar: New module.

[Amirouche Boubekki]

[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]

Thx for the review and explanation.

I am not in a hurry, I will wait for the 5.3.12 release.

On Mon, Oct 24, 2016 at 7:03 PM Amir P <amirpli@gmail.com> wrote:

> On Sun, 23 Oct 2016 17:20:11 -0400 Leo Famulari wrote:
> > If sqlite and zlib are only used when building, but not when running
> > link-grammar, then they should be native-inputs.
> >
> > Otherwise, we will need to figure out how to make link-grammar retain
> > references to these libraries.
>
> The link-grammar library doesn't use the zlib library directly or
> indirectly.
> What happens is that zlib.h is needed for the compilation of its
> sat-solver code
> because it is included in a header file of the minisat library which is
> indirectly
> included by the sat-solver code. So zlib (actually zlib.h) is only used
> when building.
>
> However, if the sqlite library+headers exist when using "configure",
> HAVE_SQLITE will get defined, which will bring in code that can use sqlite
> (sqlite3_open etc. are referenced in the result link-grammar library).
> As this code is currently not fully functional, a solution may be to
> "configure"
> link-grammar without the presence of the sqlite library+headers.
> A better solution may be to add a link-grammar "configure" option like
> "--enable-sqlite".
> If you think it is indeed better, I will open an issue there for adding it
> - to be
> included in the next version - 5.3.12.
> In any case, 5.3.12 is needed to overcome additional problems in 5.3.11
> (some
> of them are already fixed in the repository, and for some others
> pull-requests are
> still pending).
>

[-- Attachment #2: Type: text/html, Size: 3329 bytes --]