From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: link-grammar: New module.
Date: Sun, 23 Oct 2016 17:20:11 -0400
Message-ID: <20161023212011.GC20961@jasmine>
References: <CAL7_Mo_VO9zNDJeUHniNYAoqBy+jQRj-Pb4SLwjc73cHUntUNA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60698)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1byQBk-0002lm-HD
	for guix-devel@gnu.org; Sun, 23 Oct 2016 17:20:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1byQBg-00008C-VF
	for guix-devel@gnu.org; Sun, 23 Oct 2016 17:20:16 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:43852)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <leo@famulari.name>) id 1byQBg-000084-SC
	for guix-devel@gnu.org; Sun, 23 Oct 2016 17:20:12 -0400
Content-Disposition: inline
In-Reply-To: <CAL7_Mo_VO9zNDJeUHniNYAoqBy+jQRj-Pb4SLwjc73cHUntUNA@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Amirouche Boubekki <amirouche.boubekki@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>

On Sun, Oct 23, 2016 at 04:54:17PM +0200, Amirouche Boubekki wrote:
> From 391889d22f102368cc44d6a0a928fccd20810269 Mon Sep 17 00:00:00 2001
> From: Amirouche <amirouche@hypermove.net>
> Date: Sun, 23 Oct 2016 16:46:12 +0200
> Subject: [PATCH] gnu: link-grammar: New module
> 
> * gnu/packages/link-grammar.scm: New module.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add new file.

Thanks! This should go in (gnu packages language). I would have moved it
there myself if not for a different problem...

> +    (inputs `(("sqlite" ,sqlite)
> +              ("zlib" ,zlib)))

The built output of the package does not refer to sqlite or zlib:

$ guix gc --references $(./pre-inst-env guix build link-grammar)
/gnu/store/7njyh7586r6kk2lfbz2wg52n3la89zda-link-grammar-5.3.11
/gnu/store/9nifwk709wajpyfwa0jzaa3p6mf10vxs-gcc-4.9.3-lib
/gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23

This means that when the user eventually collects garbage with `guix
gc`, the sqlite and zlib libraries that link-grammar uses may be
deleted, breaking link-grammar.

If sqlite and zlib are only used when building, but not when running
link-grammar, then they should be native-inputs.

Otherwise, we will need to figure out how to make link-grammar retain
references to these libraries.