From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add libjxr. Date: Fri, 21 Oct 2016 19:58:59 -0400 Message-ID: <20161021235859.GA9570@jasmine> References: <87eg39qvjh.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="45Z9DzgjV8m4Oswq" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxjiL-0006CN-GQ for guix-devel@gnu.org; Fri, 21 Oct 2016 19:59:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxjiI-00021x-E3 for guix-devel@gnu.org; Fri, 21 Oct 2016 19:59:05 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:57670) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bxjiI-00021m-8Q for guix-devel@gnu.org; Fri, 21 Oct 2016 19:59:02 -0400 Content-Disposition: inline In-Reply-To: <87eg39qvjh.fsf@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Kei Kebreau Cc: guix-devel@gnu.org --45Z9DzgjV8m4Oswq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 21, 2016 at 04:47:14PM -0400, Kei Kebreau wrote: > This is a patch I think we need before fixing up freeimage. Thoughts? Thanks for working on this! > + (uri (string-append "mirror://debian/pool/main/j/jxrlib/jxrlib_" > + version ".orig.tar.gz")) Why not download it from the upstream site? We prefer to do that when possible. https://jxrlib.codeplex.com/releases/view/107208 > + (license > + (license:non-copyleft > + "file://Makefile" > + "See the header of the Makefile in the distribution.")) That looks like a 2 clause BSD license: https://opensource.org/licenses/BSD-2-Clause > diff --git a/gnu/packages/patches/libjxr-fix-typos.patch b/gnu/packages/patches/libjxr-fix-typos.patch > new file mode 100644 > index 0000000..3c051dd > --- /dev/null > +++ b/gnu/packages/patches/libjxr-fix-typos.patch > @@ -0,0 +1,60 @@ > +Description: Fix typos and remove some warnings > +Author: Mathieu Malaterre Can you include a link to the source of this patch? > diff --git a/gnu/packages/patches/libjxr-use-cmake.patch b/gnu/packages/patches/libjxr-use-cmake.patch > new file mode 100644 > index 0000000..cb5919e > --- /dev/null > +++ b/gnu/packages/patches/libjxr-use-cmake.patch > @@ -0,0 +1,143 @@ > +Description: Prefer a cmake based build system > +Author: Mathieu Malaterre > +Forwarded: https://jxrlib.codeplex.com/discussions/440294 Why doesn't upstream's build system work? --45Z9DzgjV8m4Oswq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYCqu/AAoJECZG+jC6yn8IS6wQAJeWjLNa4eDCyMHc8TUu4Akg i+YvI6RIIpNwnIhY4VemfHyovd7LTF56/peUUiIihbXgUxF2o1j7ABjZ54plIfWT OPRxauUWVDiYxNEuPHjq3wlRQMS+vCqYMtZ6mKuxgLRVD06F5XrI13/hhXW9QByI hv1yWXE1iZ+lyg2KD8QR++9tnU2Aky06yazQHTRG3JVKhR7UM9D3Ntl/QWYMY1Og DaTSfnwVUz3VN5+Bhjc1jx6RZblBTvBtB9b+ukG1SuZlVMXEcaFC2GBv1KCEImLg zTmjbw0Dc8oPNce0oeDOKjHdmpwRKf0jy27rOiN0k53r3dsnaQE8XxFfDbBFtmNz 5UmrAx3h0pwMPr8hHU3IeCefSS1CbdfElJ6bs1Eo+PQYifQCw8Bq69Seb4PXzonn w6PY18tRZQ3+bBscVv/r6JLzD/tsW2+V5zgDeN9NFaNCzGQVjHtV3Esas6aJ2RHG IhZAzm/UOmvZzIgV6sCHDMAOV4zivxIqNxuq/zl02WoCi1gdrBXog2WHGrc5rc0X nWai+I2P951mk3fWwAWr6cSNvVe9cY16LSOYm8zYM7IVElv+Kx77i8eqJxjETXFv RvJunukJ4CVLDZ6K1JgwcSvEX718v/eTHxf4YAvs9WPdOcUBljpbi3/9xYMuRjlo rpE5bjXLUMpfB4In50Nl =Nf7c -----END PGP SIGNATURE----- --45Z9DzgjV8m4Oswq--