From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/1] gnu: borg: Install more documentation.
Date: Wed, 19 Oct 2016 16:01:28 -0400
Message-ID: <20161019200128.GA7837@jasmine>
References: <cover.1476759536.git.leo@famulari.name>
	<3cd4136ec4d14a25c803d2dbf2e0262d37a3dc8e.1476759536.git.leo@famulari.name>
	<877f96t98o.fsf@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42770)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bwx3O-0005mc-Ld
	for guix-devel@gnu.org; Wed, 19 Oct 2016 16:01:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bwx3K-0003Lt-Qe
	for guix-devel@gnu.org; Wed, 19 Oct 2016 16:01:34 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:43683)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <leo@famulari.name>) id 1bwx3K-0003LM-LL
	for guix-devel@gnu.org; Wed, 19 Oct 2016 16:01:30 -0400
Content-Disposition: inline
In-Reply-To: <877f96t98o.fsf@elephly.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

On Tue, Oct 18, 2016 at 09:19:19AM +0200, Ricardo Wurmus wrote:
> 
> Leo Famulari <leo@famulari.name> writes:
> 
> > * gnu/packages/backup.scm (borg)[arguments]: Install more documentation
> > in 'install-doc' phase.
> > ---
> >  gnu/packages/backup.scm | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
> > index eb5e98d..b75e99b 100644
> > --- a/gnu/packages/backup.scm
> > +++ b/gnu/packages/backup.scm
> > @@ -439,8 +439,15 @@ detection, and lossless compression.")
> >           (add-after 'install 'install-doc
> >             (lambda* (#:key outputs #:allow-other-keys)
> >               (let* ((out (assoc-ref outputs "out"))
> > -                    (man (string-append out "/share/man/man1")))
> > +                    (man (string-append out "/share/man/man1"))
> > +                    (misc (string-append out "/share/borg/misc")))
> >                 (and
> > +                 (for-each (lambda (file)
> > +                             (install-file file misc))
> 
> I like “cut” from srfi-26 in simple cases like this:
> 
>     (for-each (cut install-file <> misc)
>               (find-files …))

Thanks, that is easier to read.

> > +                           (find-files "docs/misc"
> > +                                       (string-append "create_chunker-params|"
> > +                                                      "internals-picture|"
> > +                                                      "prune-example")))
> 
> I don’t think “string-append” is needed here.  You can just break the
> string and escape the line break.

I decided not to use a regex for this. It's only three files so I just
used a list.