From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 2/2] gnu: gajim: Update to 0.16.6. Date: Wed, 19 Oct 2016 13:25:55 -0400 Message-ID: <20161019172555.GE8998@jasmine> References: <20161019045005.3678-1-arunisaac@systemreboot.net> <20161019045005.3678-2-arunisaac@systemreboot.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwucp-000177-PC for guix-devel@gnu.org; Wed, 19 Oct 2016 13:26:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwucm-0005Xo-Hw for guix-devel@gnu.org; Wed, 19 Oct 2016 13:25:59 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:56574) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwucm-0005Wz-EK for guix-devel@gnu.org; Wed, 19 Oct 2016 13:25:56 -0400 Content-Disposition: inline In-Reply-To: <20161019045005.3678-2-arunisaac@systemreboot.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Arun Isaac Cc: guix-devel@gnu.org On Wed, Oct 19, 2016 at 10:20:05AM +0530, Arun Isaac wrote: > * gnu/packages/messaging.scm (gajim): Update to 0.16.6. > (arguments > - `(;; The only check done by gajim-0.16.x is to check that the > - ;; translations are up-to-date, and in 0.16.5 they are not, so > - ;; "make check" fails. Therefore, we disable tests for now. > - ;; > - ;; XXX TODO Try re-enabling tests in gajim-0.16.6 or later. > - ;; > - #:tests? #f Is that comment still true? If so, I think we can leave the tests disabled. > (add-after 'install 'wrap-program > - (lambda* (#:key outputs #:allow-other-keys) > - ;; Make sure all Python scripts run with the correct PYTHONPATH. > - (let ((out (assoc-ref outputs "out")) > - (path (getenv "PYTHONPATH"))) > - (for-each (lambda (name) > - (let ((file (string-append out "/bin/" name))) > - ;; Wrapping destroys identification of intended > - ;; application, so we need to override "APP". > - (substitute* file > - (("APP=`basename \\$0`") > - (string-append "APP=" name))) > - (wrap-program file > - `("PYTHONPATH" ":" prefix (,path))))) > - '("gajim" "gajim-remote" "gajim-history-manager"))) > - #t))))) > + (lambda* (#:key outputs #:allow-other-keys) > + ;; Make sure all Python scripts run with the correct PYTHONPATH. > + (let ((out (assoc-ref outputs "out")) > + (path (getenv "PYTHONPATH"))) > + (for-each (lambda (name) > + (let ((file (string-append out "/bin/" name))) > + ;; Wrapping destroys identification of intended > + ;; application, so we need to override "APP". > + (substitute* file > + (("APP=`basename \\$0`") > + (string-append "APP=" name))) > + (wrap-program file > + `("PYTHONPATH" ":" prefix (,path))))) > + '("gajim" "gajim-remote" "gajim-history-manager"))) > + #t))))) This is just an indentation fix, right? Just checking :)