From: Leo Famulari <leo@famulari.name>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] gnu: gajim: Update to 0.16.6.
Date: Wed, 19 Oct 2016 13:25:55 -0400 [thread overview]
Message-ID: <20161019172555.GE8998@jasmine> (raw)
In-Reply-To: <20161019045005.3678-2-arunisaac@systemreboot.net>
On Wed, Oct 19, 2016 at 10:20:05AM +0530, Arun Isaac wrote:
> * gnu/packages/messaging.scm (gajim): Update to 0.16.6.
> (arguments
> - `(;; The only check done by gajim-0.16.x is to check that the
> - ;; translations are up-to-date, and in 0.16.5 they are not, so
> - ;; "make check" fails. Therefore, we disable tests for now.
> - ;;
> - ;; XXX TODO Try re-enabling tests in gajim-0.16.6 or later.
> - ;;
> - #:tests? #f
Is that comment still true? If so, I think we can leave the tests
disabled.
> (add-after 'install 'wrap-program
> - (lambda* (#:key outputs #:allow-other-keys)
> - ;; Make sure all Python scripts run with the correct PYTHONPATH.
> - (let ((out (assoc-ref outputs "out"))
> - (path (getenv "PYTHONPATH")))
> - (for-each (lambda (name)
> - (let ((file (string-append out "/bin/" name)))
> - ;; Wrapping destroys identification of intended
> - ;; application, so we need to override "APP".
> - (substitute* file
> - (("APP=`basename \\$0`")
> - (string-append "APP=" name)))
> - (wrap-program file
> - `("PYTHONPATH" ":" prefix (,path)))))
> - '("gajim" "gajim-remote" "gajim-history-manager")))
> - #t)))))
> + (lambda* (#:key outputs #:allow-other-keys)
> + ;; Make sure all Python scripts run with the correct PYTHONPATH.
> + (let ((out (assoc-ref outputs "out"))
> + (path (getenv "PYTHONPATH")))
> + (for-each (lambda (name)
> + (let ((file (string-append out "/bin/" name)))
> + ;; Wrapping destroys identification of intended
> + ;; application, so we need to override "APP".
> + (substitute* file
> + (("APP=`basename \\$0`")
> + (string-append "APP=" name)))
> + (wrap-program file
> + `("PYTHONPATH" ":" prefix (,path)))))
> + '("gajim" "gajim-remote" "gajim-history-manager")))
> + #t)))))
This is just an indentation fix, right? Just checking :)
next prev parent reply other threads:[~2016-10-19 17:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 4:50 [PATCH 1/2] gnu: gajim: License is "version 3 only" Arun Isaac
2016-10-19 4:50 ` [PATCH 2/2] gnu: gajim: Update to 0.16.6 Arun Isaac
2016-10-19 17:25 ` Leo Famulari [this message]
2016-10-20 10:18 ` Arun Isaac
2016-10-20 11:02 ` [PATCH 1/2] gnu: gajim: License is "version 3 only" Arun Isaac
2016-10-20 11:02 ` [PATCH 2/2] gnu: gajim: Update to 0.16.6 Arun Isaac
2016-10-19 17:23 ` [PATCH 1/2] gnu: gajim: License is "version 3 only" Leo Famulari
2016-10-20 19:46 ` Ludovic Courtès
2016-10-23 6:28 ` Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019172555.GE8998@jasmine \
--to=leo@famulari.name \
--cc=arunisaac@systemreboot.net \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.