From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Security bugs in freeimage bundled libraries [was Re: 01/02: gnu:
	freeimage: Fix CVE-2016-5684.]
Date: Fri, 14 Oct 2016 13:48:20 -0400
Message-ID: <20161014174820.GA30644@jasmine>
References: <20161014104404.22087.86582@vcs.savannah.gnu.org>
	<20161014104405.901E322012A@vcs.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56619)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bv6aw-0002VO-Fe
	for guix-devel@gnu.org; Fri, 14 Oct 2016 13:48:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bv6as-0003aG-Rs
	for guix-devel@gnu.org; Fri, 14 Oct 2016 13:48:34 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:44760)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <leo@famulari.name>) id 1bv6ar-0003Xg-GL
	for guix-devel@gnu.org; Fri, 14 Oct 2016 13:48:30 -0400
Content-Disposition: inline
In-Reply-To: <20161014104405.901E322012A@vcs.savannah.gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel@gnu.org

On Fri, Oct 14, 2016 at 10:44:05AM +0000, Efraim Flashner wrote:
> efraim pushed a commit to branch master
> in repository guix.
> 
> commit 76e8566c1b3c4876d649e712a5c8c473fd48d134
> Author: Efraim Flashner <efraim@flashner.co.il>
> Date:   Fri Oct 14 11:28:21 2016 +0300
> 
>     gnu: freeimage: Fix CVE-2016-5684.
>     
>     * gnu/packages/image.scm (freeimage)[source]: Add patch.
>     * gnu/packages/patches/freeimage-CVE-2016-5684.patch: New file.
>     * gnu/local.mk (dist_patch_DATA): Register it.
> ---
>  gnu/local.mk                                       |    1 +
>  gnu/packages/image.scm                             |    3 +-
>  gnu/packages/patches/freeimage-CVE-2016-5684.patch |   34 ++++++++++++++++++++
>  3 files changed, 37 insertions(+), 1 deletion(-)

Efraim pointed out on IRC that our freeimage packages bundles many
3rd-party libraries:

$ ls -1 FreeImage/Source
CacheFile.h
DeprecationManager
FreeImage
FreeImage.h
FreeImageIO.h
FreeImageLib
FreeImageToolkit
LibJPEG
LibJXR
LibOpenJPEG
LibPNG
LibRawLite
LibTIFF4
LibWebP
MapIntrospector.h
Metadata
OpenEXR
Plugin.h
Quantizers.h
ToneMapping.h
Utilities.h
ZLib

Debian has a patch to make it use "system" copies of the libraries:

https://anonscm.debian.org/cgit/debian-science/packages/freeimage.git/tree/debian/patches/Disable-vendored-dependencies.patch?h=debian/sid

For now, our freeimage package is probably vulnerable to many publicly
disclosed security bugs.

Who volunteers to try fixing this?