From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH 1/1] services: ntpd: Make large clock adjustments if necessary. Date: Thu, 13 Oct 2016 07:06:50 +0200 Message-ID: <20161013050650.GA25727@jocasta.intra> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qDbXVdCdHGoSgWSk" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buYEY-0004GX-LB for guix-devel@gnu.org; Thu, 13 Oct 2016 01:07:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buYEU-0004Gg-Dg for guix-devel@gnu.org; Thu, 13 Oct 2016 01:07:09 -0400 Received: from de.cellform.com ([88.217.224.109]:57322 helo=jocasta.intra) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buYEU-0004Au-4X for guix-devel@gnu.org; Thu, 13 Oct 2016 01:07:06 -0400 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org --qDbXVdCdHGoSgWSk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I think that this should be a configuration item in the service, so that the user can decide whether to have it or not. I don't think we should force it on the user. Some applications break if the clock makes large jumps. The ntpd authors decided that the default behaviour is not to make large ju= mps so I think we should respect that unless there is a good reason to do other= wise. So I think this should be configurable in /etc/config.scm and the default s= hould be not to use -g J' On Wed, Oct 12, 2016 at 07:21:07PM -0400, Leo Famulari wrote: If the system clock is more than 1000 seconds off, ntpd will exit with= out adjusting the clock. =20 Reported by reepca on #guix. =20 * gnu/services/networking.scm (ntp-shepherd-service): Pass '-g' when starting the NTP daemon. --- gnu/services/networking.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) =20 diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm index 7495179..5261e38 100644 --- a/gnu/services/networking.scm +++ b/gnu/services/networking.scm @@ -296,7 +296,7 @@ restrict -6 ::1\n")) (requirement '(user-processes networking)) (start #~(make-forkexec-constructor (list (string-append #$ntp "/bin/ntpd") "-n" - "-c" #$ntpd.conf "-u" "ntpd"))) + "-c" #$ntpd.conf "-u" "ntpd" "-g"))) (stop #~(make-kill-destructor)))))))) =20 (define %ntp-accounts --=20 2.10.1 =20 --=20 Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --qDbXVdCdHGoSgWSk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlf/FmoACgkQimdxnC3oJ7PRAQCfZhazQrjzwhAmmJUdKtu/BF2+ COgAnicdfdRBFOCHKWQeUOUl+piHQn6V =p3fc -----END PGP SIGNATURE----- --qDbXVdCdHGoSgWSk--