From: ludo@gnu.org (Ludovic Courtès)
Subject: Re: [PATCH] gnu: Add hdf4
Date: Wed, 12 Oct 2016 14:54:40 +0200

>>  - I've also added a variant “hdf4-alt”: by default, HDF4 includes 
>> a
>>    netCDF API to access HDF4 files, which clashes with the symbols 
>> in
>>    the real netCDF library when you try to use both libraries in 
>> your
>>    program.  This variant uses the “--disable-netcdf” configure 
>> flag
>>    to avoid this.  We could call it “hdf4-nonetcdf”, but the name
>>    “hdf4-alt” is used by Debian, so maybe it's good to use the 
>> same?
>
> Would “hdf4-minimal” sound appropriate here?  That’s a convention 
> we use
> in similar cases.  Otherwise “hdf4-alt” is fine with me.

With --disable-netcdf, the library still includes all the same 
features, the netCDF API function names are just mangled to avoid 
conflicts.  So it's not really more “minimal” than the regular HDF4 
:-)  I'd either go for something that explicitly mentions netCDF, or 
hdf4-alt because that's what Debian uses.

>> +             (substitute*
>> +                 (map (lambda (dir) (string-append dir 
>> "/Makefile.in"))
>> +                      '("hdf" "hdf/examples" "hdf/fortran" 
>> "hdf/src"
>> +                        "hdf/test" "hdf/util" "mfhdf" 
>> "mfhdf/dumper"
>> +                        "mfhdf/examples" "mfhdf/fortran" 
>> "mfhdf/hdfimport"
>> +                        "mfhdf/hdiff" "mfhdf/hrepack" 
>> "mfhdf/libsrc"
>> +                        "mfhdf/ncgen" "mfhdf/ncdump" 
>> "mfhdf/nctest"
>> +                        "mfhdf/test" "mfhdf/xdr"))
>
> Maybe simply (find-files "." "^Makefile\\.in$")?

Yes, I was convinced something like that had to exist, but am not 
good at reading the docs, it seems.

> - CONFIG_DATE="`date`"
> + CONFIG_DATE="$SOURCE_DATE_EPOCH"
>
> The smaller the patch, the better.  :-)

I went with

+CONFIG_DATE=`date -u -d "@$SOURCE_DATE_EPOCH"`

(which just results in 1 Jan 1970, but anyway)

cheers,

Thomas