From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Patterson Subject: Re: [PATCH 0/12]: Add asdf-build-system. Date: Mon, 10 Oct 2016 15:24:30 -0230 Message-ID: <20161010152430.55be0e26@uwaterloo.ca> References: <20160927041532.27097-1-ajpatter@uwaterloo.ca> <8737k7hu6s.fsf@gnu.org> <871szrvuk1.fsf@member.fsf.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btemg-0007jy-80 for guix-devel@gnu.org; Mon, 10 Oct 2016 13:54:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btemb-0004UM-A8 for guix-devel@gnu.org; Mon, 10 Oct 2016 13:54:41 -0400 In-Reply-To: <871szrvuk1.fsf@member.fsf.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?UTF-8?B?5a6L5paH5q2m?= Cc: guix-devel@gnu.org Hi. On Sat, 08 Oct 2016 21:28:46 +0800 iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) wrote: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: >=20 > > I browsed the patch series quickly; the packages I did not comment > > on LGTM, modulo the question of whether we should prefix them. > > =20 >=20 > Thanks for the review! I push them :-) >=20 > (the V2 patches already use prefix names.) Thanks, and especially for the review and suggestions. Could you also take a look at the fix for ecl which I posted at ? Without it, the ecl packages are a bit broken, for example: $ guix environment --container --ad-hoc ecl ecl-slynk -- ecl -eval \ "(mapc 'require '(asdf slynk))"=20 which should give you a REPL with slynk loaded, but instead fails. As I said, I'll try to get it fixed upstream for their next release. Thanks, -- Andy