From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: mail: Add notifymuch. Date: Sun, 9 Oct 2016 18:08:38 -0400 Message-ID: <20161009220838.GC18927@jasmine> References: <20161009213318.29189-1-mail@cbaines.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btMH7-00065k-E9 for guix-devel@gnu.org; Sun, 09 Oct 2016 18:08:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btMH4-000742-32 for guix-devel@gnu.org; Sun, 09 Oct 2016 18:08:53 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:35247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btMH2-0006zU-4v for guix-devel@gnu.org; Sun, 09 Oct 2016 18:08:49 -0400 Content-Disposition: inline In-Reply-To: <20161009213318.29189-1-mail@cbaines.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Christopher Baines Cc: guix-devel@gnu.org On Sun, Oct 09, 2016 at 10:33:18PM +0100, Christopher Baines wrote: > * gnu/packages/mail.scm (notifymuch): New variable. Thanks for this patch! > + (version "0.1") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/kspi/notifymuch.git") > + (commit "9d4aaf54599282ce80643b38195ff501120807f0"))) There are no "real" releases, right? I didn't see a 0.1 version on the home-page. If so, can you revise this patch to use the versioning method described in the manual, section 7.6.3 Version Numbers [0]? So, the resulting version string would be 0.0.0-1.9d4aaf5. There is a recent example in 4b51b21ccf (gnu: Add cl-clx.). By the way, for anyone reading along, the commit chosen by Christopher is the current HEAD of the master branch. > + (add-after 'install 'wrap-binary > + (lambda* (#:key inputs outputs #:allow-other-keys) I think 'inputs' can be removed since it isn't used here. Looks good with these changes! [0] https://www.gnu.org/software/guix/manual/html_node/Version-Numbers.html