all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Christopher Baines <mail@cbaines.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: mail: Add notifymuch.
Date: Sun, 9 Oct 2016 18:08:38 -0400	[thread overview]
Message-ID: <20161009220838.GC18927@jasmine> (raw)
In-Reply-To: <20161009213318.29189-1-mail@cbaines.net>

On Sun, Oct 09, 2016 at 10:33:18PM +0100, Christopher Baines wrote:
> * gnu/packages/mail.scm (notifymuch): New variable.

Thanks for this patch!

> +    (version "0.1")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/kspi/notifymuch.git")
> +             (commit "9d4aaf54599282ce80643b38195ff501120807f0")))

There are no "real" releases, right? I didn't see a 0.1 version on the
home-page.

If so, can you revise this patch to use the versioning method described
in the manual, section 7.6.3 Version Numbers [0]?

So, the resulting version string would be 0.0.0-1.9d4aaf5.

There is a recent example in 4b51b21ccf (gnu: Add cl-clx.).

By the way, for anyone reading along, the commit chosen by Christopher
is the current HEAD of the master branch.

> +         (add-after 'install 'wrap-binary
> +           (lambda* (#:key inputs outputs #:allow-other-keys)

I think 'inputs' can be removed since it isn't used here.

Looks good with these changes!

[0]
https://www.gnu.org/software/guix/manual/html_node/Version-Numbers.html

  reply	other threads:[~2016-10-09 22:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-09 21:33 [PATCH] gnu: mail: Add notifymuch Christopher Baines
2016-10-09 22:08 ` Leo Famulari [this message]
2016-10-10  6:44   ` Christopher Baines
2016-10-10  6:44     ` Christopher Baines
2016-10-10  7:40 ` Hartmut Goebel
2016-10-10  7:52   ` Alex Kost
2016-10-10  8:12     ` Hartmut Goebel
2016-10-12 18:17   ` Christopher Baines
2016-10-13  7:58     ` Hartmut Goebel
2016-10-13 20:10       ` Ludovic Courtès
2016-10-14  9:30         ` Hartmut Goebel
2016-10-16 17:20           ` Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161009220838.GC18927@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.