From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: [PATCH 5/6] gnu: make-u-boot-package: Add files-to-install argument. Date: Fri, 7 Oct 2016 11:26:45 +0200 Message-ID: <20161007112645.5ea15d6c@scratchpost.org> References: <20160926103447.31830-1-david@craven.ch> <20160926103447.31830-5-david@craven.ch> <20160926143926.14eccdc3@scratchpost.org> <20160926160438.70451325@scratchpost.org> <20160927002843.39d0d786@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsRQj-0000Xd-My for guix-devel@gnu.org; Fri, 07 Oct 2016 05:27:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsRQf-0006j7-Es for guix-devel@gnu.org; Fri, 07 Oct 2016 05:27:00 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:34667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsRQf-0006fI-73 for guix-devel@gnu.org; Fri, 07 Oct 2016 05:26:57 -0400 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: David Craven Cc: guix-devel Hi David, On Fri, 7 Oct 2016 10:19:42 +0200 David Craven wrote: > > Ughh... are we sure we want to do that? I don't think a > > regular user would know what to put there. If the U-Boot > > build is from a clean slate it's not like there are stray files > > lying around or anything - we can just copy them all if we > > want. > > I thought about this patch and I think we should add it. The regex > solution results in a lot of garbage inside the output directory. > Regular users don't compile u-boot, and anyone with the skills to port > guixsd to a new board will know what to put. It also serves as > documentation, from reading the package definition I can tell what the > relevant files are without examining the output directory (which is > full of garbage - so I have to google it anyway). Yeah, if there are a lot of garbage files I also think that it's okay to do it like you propose. (It's just something that we have been struggling with in the ARM world - people think their board is the only one and then you have some custom configuration which only works for their board for no good reason. In this case the U-Boot binaries (contents) are rightfully board-specific. But there's no good reason that the names and splitting-up-into-files are (or the installation process - it's 2016, a computer should automate the installation). I'll mention it upstream) I wonder how U-Boot itself finds out the target names - but that's for a future patch. (I think one could examine ALL-y to find out) So I agree. LTGM!