From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add libdispatch. Date: Sat, 1 Oct 2016 20:39:05 -0400 Message-ID: <20161002003905.GA24418@jasmine> References: <87poo4m84e.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YiEDa0DAkWCtVeE4" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqUoX-0008Dr-2z for guix-devel@gnu.org; Sat, 01 Oct 2016 20:39:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqUoR-0006LU-C5 for guix-devel@gnu.org; Sat, 01 Oct 2016 20:39:32 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:58263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqUoO-0006HK-Pw for guix-devel@gnu.org; Sat, 01 Oct 2016 20:39:27 -0400 Content-Disposition: inline In-Reply-To: <87poo4m84e.fsf@we.make.ritual.n0.is> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org --YiEDa0DAkWCtVeE4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 16, 2016 at 10:50:09AM +0000, ng0 wrote: > Subject: [PATCH 1/4] gnu: Add libkqueue. >=20 > * gnu/local.mk: Include gnu/packages/libdispatch.scm . > * gnu/packages/libdispatch.scm: Add new file. > * gnu/packages/libdispatch.scm (libkqueue): New variable. LGTM > Subject: [PATCH 2/4] gnu: Add libpthread_workqueue. >=20 > * gnu/packages/libdispatch.scm (libpthread_workqueue): New variable. > + (version "0.9.1") 0.9.2 is available upstream: https://github.com/mheily/libpwq/releases Can you try using that? > Subject: [PATCH 3/4] gnu: Add libblocks-runtime. >=20 > * gnu/packages/libdispatch.scm (libblocks-runtime): New variable. > + (add-after 'unpack 'autogen > + (lambda _ > + (zero? (system* "autoreconf" "--install" "--symlink" "--ver= bose"))))))) Why use --symlink? > Subject: [PATCH 4/4] gnu: Add libdispatch. >=20 > * gnu/packages/libdispatch.scm (libdispatch): New variable. > + (arguments > + `(#:tests? #f)) The tests can be run with `ctest` [0]. The test suite can be built by setting "-DDISPATCH_ENABLE_TEST_SUITE=3D1" in #:configure-flags. However, when I tried that, the build log included "No compiler support for Blocks; test suite will not be built.", and the tests were indeed not built. Does that mean that libblocks-runtime is not working? Also, the libdispatch tarball bundles Click [0] at 'thirdparty/click'. We should remove that and use our Click package. [0] https://github.com/nickhutchinson/libdispatch#testing-with-ctest [1] http://click.pocoo.org/5/ --YiEDa0DAkWCtVeE4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIbBAEBCAAGBQJX8FclAAoJECZG+jC6yn8IEsoP9jdNZ+mi5334haxXdQTTKyKL ml00f5sb6XodQAIZkuzuFgt8nwHVwbFoAMfKaYrO68xfMXIrZwkR6bIPUUthXn2B h6XQWfqJI0aRUiyKCOqRzMmiIgMeOCQa2IFlJgcLss8mJdMjJseh4VYcbZLhAI5+ EsVzvjHL7QhDu3nM1orYd6aO3TuSVojmPRnArzjaYXhbSknMoUxOyDt8JoVjaMh0 oPmspm467Q4+jiK2GcaIBelGG1b5lSJxi/dhC76WYNlcmeK4yNs+4WbLBz2wo/Ky x8m6XUhA+blOB6IxKaNNgTF+qfcB+iryxpb6+DopOURf7dq+uuzKuZgERuirWwAo axgZ4Um7yLEQZiitRrN/tZLSl9MZdI8ljrGpH/O1x7zS8I5HxnzlTgrE8q14/cg2 IIrk3mTqBcBFPhGOHESxggbZu4mI/hrxq1pmbJVZ3ATdySlPVLd+Or+dgg7dLvKp K2MUCMsdOfTYX9qDikHYPfl55LtK9XSoKk5g319hJSWVIkdEHmSEc6Le+lus5IkC iQBMZiRhN2BRgoFBvrnIilFEp9A/A8bil+WAkETuAjQsDh78+GUjOjC910mZfsoW yY0Fz8Jt8xm1r+znCkepxkhUpUT6ZpaJg327uxx7XxSx69fusnzQ403slPJZaMNT aXf2vuCfbIrQdCju+lY= =Nv2Y -----END PGP SIGNATURE----- --YiEDa0DAkWCtVeE4--