From: Leo Famulari <leo@famulari.name>
To: ng0 <ng0@we.make.ritual.n0.is>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add libdispatch.
Date: Sat, 1 Oct 2016 20:39:05 -0400 [thread overview]
Message-ID: <20161002003905.GA24418@jasmine> (raw)
In-Reply-To: <87poo4m84e.fsf@we.make.ritual.n0.is>
[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]
On Fri, Sep 16, 2016 at 10:50:09AM +0000, ng0 wrote:
> Subject: [PATCH 1/4] gnu: Add libkqueue.
>
> * gnu/local.mk: Include gnu/packages/libdispatch.scm .
> * gnu/packages/libdispatch.scm: Add new file.
> * gnu/packages/libdispatch.scm (libkqueue): New variable.
LGTM
> Subject: [PATCH 2/4] gnu: Add libpthread_workqueue.
>
> * gnu/packages/libdispatch.scm (libpthread_workqueue): New variable.
> + (version "0.9.1")
0.9.2 is available upstream:
https://github.com/mheily/libpwq/releases
Can you try using that?
> Subject: [PATCH 3/4] gnu: Add libblocks-runtime.
>
> * gnu/packages/libdispatch.scm (libblocks-runtime): New variable.
> + (add-after 'unpack 'autogen
> + (lambda _
> + (zero? (system* "autoreconf" "--install" "--symlink" "--verbose")))))))
Why use --symlink?
> Subject: [PATCH 4/4] gnu: Add libdispatch.
>
> * gnu/packages/libdispatch.scm (libdispatch): New variable.
> + (arguments
> + `(#:tests? #f))
The tests can be run with `ctest` [0].
The test suite can be built by setting "-DDISPATCH_ENABLE_TEST_SUITE=1"
in #:configure-flags. However, when I tried that, the build log included
"No compiler support for Blocks; test suite will not be built.", and the
tests were indeed not built.
Does that mean that libblocks-runtime is not working?
Also, the libdispatch tarball bundles Click [0] at 'thirdparty/click'. We
should remove that and use our Click package.
[0]
https://github.com/nickhutchinson/libdispatch#testing-with-ctest
[1]
http://click.pocoo.org/5/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-10-02 0:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 10:50 [PATCH] gnu: Add libdispatch ng0
2016-10-02 0:39 ` Leo Famulari [this message]
2016-10-03 11:57 ` ng0
2016-10-28 11:23 ` ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161002003905.GA24418@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=ng0@we.make.ritual.n0.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.