From: Danny Milosavljevic <dannym@scratchpost.org>
To: Theodoros Foradis <theodoros.for@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH v3 0/6] Add FPGA Tools
Date: Fri, 30 Sep 2016 08:23:41 +0200 [thread overview]
Message-ID: <20160930082341.4d82a1ee@scratchpost.org> (raw)
In-Reply-To: <87vaxebaaq.fsf@openmailbox.org>
> I tested the patches again, and they are working correctly after the fix in
> libftdi. Should we still delete "-I/usr/local/include" from the makefile
> of icestorm to ensure it doesn't build wrongly in non-guixsd systems or is
> it unnecessary?
Yes. I'm sorry, I thought I added the part removing that - but apparently not. It can be added when merging or I or anyone else can send an updated patchset - whichever we prefer. The change would be:
(substitute* "iceprog/Makefile"
(("-I/usr/local/include") "") ; added
(("-L/usr/local/lib") ""))))
Should we have a phase checking that in Guix in the future (which just does "grep -r /usr ." in the package)? Maybe overkill but it would catch something like this automatically.
> Gtkwave is fine as well. Maybe we would like to add it in
> another file though (e.g. engineering.scm), in case it's used with
> other packages in the future.
engineering.scm would be good to use for all FPGA tools. On the other hand, now you have all the packages for FPGA development in one place - which isn't bad either.
I guess putting just gtkwave there would be good. In any case, I don't have a preference because I don't use the categories for anything as a user anymore.
next prev parent reply other threads:[~2016-09-30 6:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 0:04 [PATCH v3 0/6] Add FPGA Tools Danny Milosavljevic
2016-09-27 0:04 ` [PATCH v3 1/6] gnu: Add abc Danny Milosavljevic
2016-09-27 0:04 ` [PATCH v3 2/6] gnu: Add iverilog Danny Milosavljevic
2016-09-27 0:04 ` [PATCH v3 3/6] gnu: Add yosys Danny Milosavljevic
2016-09-27 0:04 ` [PATCH v3 4/6] gnu: Add icestorm Danny Milosavljevic
2016-09-27 0:04 ` [PATCH v3 5/6] gnu: Add arachne-pnr Danny Milosavljevic
2016-09-27 0:05 ` [PATCH v3 6/6] gnu: Add gtkwave Danny Milosavljevic
2016-09-29 22:39 ` [PATCH v3 0/6] Add FPGA Tools Theodoros Foradis
2016-09-30 6:23 ` Danny Milosavljevic [this message]
2016-10-08 14:31 ` Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160930082341.4d82a1ee@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
--cc=theodoros.for@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.