all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: guix-devel@gnu.org
Subject: Fw: [PATCH] guix: python-build-system: Honor configure-flags also when building
Date: Thu, 29 Sep 2016 13:57:10 +0200	[thread overview]
Message-ID: <20160929135710.6f3b7076@scratchpost.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

(Hmm, maybe this patch was not seen because it's so far down in the thread 
"Stuck on KiCad dependency wxPython". So I'm resending it to the top.)

While there was already a #:configure-flags for the "install" target,
it was not used when building. Use it.

* guix/build/python-build-system.scm (build): Modified.
---
 guix/build/python-build-system.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

[-- Attachment #2: 0001-guix-python-build-system-Honor-configure-flags-also-.patch --]
[-- Type: text/x-patch, Size: 644 bytes --]

diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
index 9109fb4..65824a3 100644
--- a/guix/build/python-build-system.scm
+++ b/guix/build/python-build-system.scm
@@ -44,9 +44,9 @@
          (zero? (apply system* "python" "setup.py" command params)))
       (error "no setup.py found")))
 
-(define* (build #:rest empty)
+(define* (build #:key (configure-flags '()) #:allow-other-keys)
   "Build a given Python package."
-  (call-setuppy "build" '()))
+  (call-setuppy "build" configure-flags))
 
 (define* (check #:key tests? test-target #:allow-other-keys)
   "Run the test suite of a given Python package."

             reply	other threads:[~2016-09-29 11:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-29 11:57 Danny Milosavljevic [this message]
2016-09-30  8:36 ` Fw: [PATCH] guix: python-build-system: Honor configure-flags also when building Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160929135710.6f3b7076@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.