From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] mailmanclient
Date: Wed, 28 Sep 2016 13:48:50 -0400
Message-ID: <20160928174850.GB14001@jasmine>
References: <87intgaren.fsf@we.make.ritual.n0.is>
	<20160928171449.GA11989@jasmine>
	<87d1joaqcf.fsf@we.make.ritual.n0.is>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47222)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bpIyf-0005fB-9V
	for guix-devel@gnu.org; Wed, 28 Sep 2016 13:49:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bpIyb-0008Cs-5B
	for guix-devel@gnu.org; Wed, 28 Sep 2016 13:49:04 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:57231)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bpIyZ-00089a-Up
	for guix-devel@gnu.org; Wed, 28 Sep 2016 13:49:01 -0400
Content-Disposition: inline
In-Reply-To: <87d1joaqcf.fsf@we.make.ritual.n0.is>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: ng0 <ngillmann@runbox.com>
Cc: guix-devel@gnu.org

On Wed, Sep 28, 2016 at 05:25:52PM +0000, ng0 wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > [ Unknown signature status ]
> > On Wed, Sep 28, 2016 at 05:02:56PM +0000, ng0 wrote:
> >> Subject: [PATCH] gnu: Add python-mailmanclient.
> >> 
> >> * gnu/packages/mail.scm (python-mailmanclient): New variable.
> >
> >> +(define-public python2-mailmanclient
> >> +  (let ((base (package-with-python2
> >> +               (strip-python2-variant python-mailmanclient))))
> >> +    (package (inherit base)
> >> +      (native-inputs
> >> +       `(("python2-setuptools" ,python2-setuptools))))))
> >
> > This variant will not be used unless there is a python2-variant
> > properties field in python-mailman, like this:
> >
> > (properties `((python2-variant . ,(delay python2-mailmanclient))))
> >
> > You can see the recent commit "gnu: Add python-q. (e8c9b01090)" for an
> > example in context.
> 
> Is this necessary for all python2 package variants? I rarely see this.

For any use of the python2-variant system, yes. I replied to a lot of
your submitted packages a couple days ago to point out that they needed
this change.

If you are just doing a plain package-with-python2 transformation, then
it's not required. Python2-variant is used when package-with-python2 is
not enough, because there are extra inputs, arguments, etc.