From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant. Date: Mon, 26 Sep 2016 20:00:17 +0200 Message-ID: <20160926180017.GA25959@jocasta.intra> References: <20160926103447.31830-1-david@craven.ch> <20160926103447.31830-4-david@craven.ch> <20160926132344.GA23258@jocasta.intra> <20160926164934.GA25011@jocasta.intra> <20160926173109.GB4625@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ReaqsoxgOBHFXBhH" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boaCg-0005Hl-GV for guix-devel@gnu.org; Mon, 26 Sep 2016 14:00:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boaCc-0007HE-1k for guix-devel@gnu.org; Mon, 26 Sep 2016 14:00:34 -0400 Received: from de.cellform.com ([88.217.224.109]:56834 helo=jocasta.intra) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boaCb-0007GQ-QE for guix-devel@gnu.org; Mon, 26 Sep 2016 14:00:29 -0400 Content-Disposition: inline In-Reply-To: <20160926173109.GB4625@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel --ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 26, 2016 at 01:31:09PM -0400, Leo Famulari wrote: On Mon, Sep 26, 2016 at 06:49:34PM +0200, John Darrington wrote: > Our current convention for commit messages is aesthetically pleasing, > but useless. It is redundant to put in the message WHAT has change= d. > That can be easily determined by running "git show". What is much > more usefull is the reason WHY we changed it. =20 I find the GNU changelog style to be very useful when reading the Git log.=20 =20 There are certain types of commits that we make over and over again, especially with packages (updates, adding inputs, etc), and I find it helpful when their commit messages follow a common format. =20 I agree that commits that don't conform to one of those types should have some explanation. This is why I often rewrite commit messages when I am committing on behalf of somebody else. =20 But there is a value to "aesthetic" consistency. It's just like having standards for code style in my opinion. It helps a lot when reading others' commits. I don't object to a having a common style. I just wish that the informati= on that we put in our messages a) gave the rationale for the change; and b) di= dn't merely repeat information which git show could have told me. J' --=20 Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlfpYjEACgkQimdxnC3oJ7NukACffGSmi47DO/yHOqcyQydn8Qpx CyQAmwXprLYB8LCmFwTQkjOKwet+9zp1 =77fi -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH--