all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: John Darrington <john@darrington.wattle.id.au>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.
Date: Mon, 26 Sep 2016 13:31:09 -0400	[thread overview]
Message-ID: <20160926173109.GB4625@jasmine> (raw)
In-Reply-To: <20160926164934.GA25011@jocasta.intra>

[-- Attachment #1: Type: text/plain, Size: 967 bytes --]

On Mon, Sep 26, 2016 at 06:49:34PM +0200, John Darrington wrote:
> Our current convention for commit messages is aesthetically pleasing,
> but useless.   It is redundant to put in the message WHAT has changed.
> That can be easily determined by running "git show".   What is much
> more usefull is the reason WHY we changed it.

I find the GNU changelog style to be very useful when reading the Git
log. 

There are certain types of commits that we make over and over again,
especially with packages (updates, adding inputs, etc), and I find it
helpful when their commit messages follow a common format.

I agree that commits that don't conform to one of those types should
have some explanation. This is why I often rewrite commit messages when
I am committing on behalf of somebody else.

But there is a value to "aesthetic" consistency. It's just like having
standards for code style in my opinion. It helps a lot when reading
others' commits.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2016-09-26 17:31 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-26 10:34 [PATCH 1/6] gnu: Add picocom David Craven
2016-09-26 10:34 ` [PATCH 2/6] gnu: %default-extra-linux-options: Remove redundant options David Craven
2016-09-29  8:40   ` Ludovic Courtès
2016-09-29  8:53     ` David Craven
2016-09-29 10:33       ` David Craven
2016-09-29 12:35         ` Ludovic Courtès
2016-09-26 10:34 ` [PATCH 3/6] gnu: make-linux-libre: Install device tree files David Craven
2016-09-26 10:34 ` [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant David Craven
2016-09-26 13:23   ` John Darrington
2016-09-26 13:25     ` David Craven
2016-09-26 14:24     ` Vincent Legoll
2016-09-26 15:57       ` Ricardo Wurmus
2016-09-26 16:49       ` John Darrington
2016-09-26 16:57         ` Vincent Legoll
2016-09-26 17:31         ` Leo Famulari [this message]
2016-09-26 18:00           ` John Darrington
2016-09-26 18:06             ` David Craven
2016-09-26 18:22               ` Vincent Legoll
2016-09-26 18:28                 ` David Craven
2016-09-26 18:34               ` Leo Famulari
2016-09-28 21:13             ` Ludovic Courtès
2016-09-27 10:47         ` Tobias Geerinckx-Rice
2016-09-28  0:14         ` Mark H Weaver
2016-09-28  6:16           ` John Darrington
2016-09-28 21:15           ` Ludovic Courtès
2016-09-28 21:11       ` Ludovic Courtès
2016-10-03 12:49         ` Vincent Legoll
2016-10-03 15:40           ` Ludovic Courtès
2016-10-04 14:32             ` Vincent Legoll
2016-09-26 10:34 ` [PATCH 5/6] gnu: make-u-boot-package: Add files-to-install argument David Craven
2016-09-26 12:39   ` Danny Milosavljevic
2016-09-26 13:38     ` David Craven
2016-09-26 13:41       ` David Craven
2016-09-26 14:04         ` Danny Milosavljevic
2016-09-26 14:07           ` David Craven
2016-09-26 22:28             ` Danny Milosavljevic
2016-10-07  8:19               ` David Craven
2016-10-07  9:26                 ` Danny Milosavljevic
2016-09-26 10:34 ` [PATCH 6/6] gnu: make-u-boot-package: Don't cross compile on arm David Craven
2016-09-26 17:24 ` [PATCH 1/6] gnu: Add picocom Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160926173109.GB4625@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=john@darrington.wattle.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.