From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: Superseded packages Date: Mon, 26 Sep 2016 12:44:41 +0300 Message-ID: <20160926094441.GF3742@macbook42.flashner.co.il> References: <20160904184416.GB29947@jasmine> <87d1kirc4r.fsf@gnu.org> <87vay8r9r3.fsf_-_@gnu.org> <20160910172514.GA28562@jasmine> <87a8felfb9.fsf@gnu.org> <20160911151945.GB6400@jasmine> <87bmzujhn7.fsf@gnu.org> <20160920211833.GA3354@jasmine> <87y42if3hq.fsf@gnu.org> <20160925164208.GA7317@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fwqqG+mf3f7vyBCB" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39092) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boST3-0007xt-6r for guix-devel@gnu.org; Mon, 26 Sep 2016 05:44:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boSSy-0007yH-Ut for guix-devel@gnu.org; Mon, 26 Sep 2016 05:44:57 -0400 Content-Disposition: inline In-Reply-To: <20160925164208.GA7317@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org --fwqqG+mf3f7vyBCB Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 25, 2016 at 12:42:08PM -0400, Leo Famulari wrote: > On Sat, Sep 24, 2016 at 11:14:41AM +0900, Ludovic Court=C3=A8s wrote: > > Leo Famulari skribis: > > > +(define-public attic > > > + (package (inherit borg) > > > + (name "attic") > > > + (properties `((superseded . ,borg))))) > >=20 > > I was thinking that we could keep the =E2=80=98attic=E2=80=99 recipe as= -is, only with > > this extra =E2=80=98properties=E2=80=99 field. > >=20 > > That way, =E2=80=9Cguix package -u=E2=80=9D and =E2=80=9Cguix package -= i attic=E2=80=9D would install > > Borg, but people who insist could still run: > >=20 > > guix package -e '(@ (gnu packages backup) attic)' > >=20 > > Thoughts? >=20 > That's a much better idea than what I had proposed. >=20 > I found that I had to move the attic package definition below borg's, or > else the borg variable was unbound when building (gnu packages backup): >=20 > ------ > Compiling Scheme modules... > LOAD (gnu packages backup) > ;;; note: source file ./gnu/packages/backup.scm > ;;; newer than compiled /home/leo/work/guix/gnu/packages/backup.go > Backtrace: > In ice-9/boot-9.scm: > 2401: 19 [save-module-excursion #] > 4052: 18 [#] > 1724: 17 [%start-stack load-stack ...] > 1729: 16 [#] > In unknown file: > ?: 15 [primitive-load "/home/leo/work/guix/./build-aux/compile-all.scm= "] > In ice-9/eval.scm: > 432: 14 [eval # #] > In ice-9/boot-9.scm: > 768: 13 [for-each # ("gnu/packages/backu= p.scm")] > 2864: 12 [resolve-interface (gnu packages backup) #:select ...] > 2789: 11 [# # ...] > 3065: 10 [try-module-autoload (gnu packages backup) #f] > 2401: 9 [save-module-excursion #] > 3085: 8 [#] > In unknown file: > ?: 7 [primitive-load-path "gnu/packages/backup" ...] > In ice-9/eval.scm: > 432: 6 [eval # ()] > 453: 5 [eval # ()] > 411: 4 [eval # #] > 387: 3 [eval # #] > 387: 2 [eval # #] > 393: 1 [eval # #] > In unknown file: > ?: 0 [memoize-variable-access! # #] >=20 > ERROR: In procedure memoize-variable-access!: > ERROR: Unbound variable: borg > ------ >=20 > So the attached patch moves attic after borg and supersedes it. Is it > expected that we have to shuffle the package definition around like > this? > From 43a18f5c9abb22454c564ac16b2c24bf2766c220 Mon Sep 17 00:00:00 2001 > From: Leo Famulari > Date: Fri, 23 Sep 2016 23:36:48 -0400 > Subject: [PATCH] gnu: attic: Superseded by borg. >=20 > * gnu/packages/backup.scm (attic)[properties]: New field. > --- > gnu/packages/backup.scm | 85 +++++++++++++++++++++++++------------------= ------ > 1 file changed, 43 insertions(+), 42 deletions(-) >=20 > diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm > index e77c4f2..c6f1321 100644 > --- a/gnu/packages/backup.scm > +++ b/gnu/packages/backup.scm > @@ -358,48 +358,6 @@ to a remote location, and only the differences will = be transmitted. Finally, > rdiff-backup is easy to use and settings have sensible defaults.") > (license license:gpl2+))) > =20 > -(define-public attic > - (package > - (name "attic") > - (version "0.16") > - (source (origin > - (method url-fetch) > - (uri (string-append > - "https://pypi.python.org/packages/source/A/Attic/Att= ic-" > - version ".tar.gz")) > - (sha256 > - (base32 > - "0b5skd36r4c0915lwpkqg5hxm49gls9pprs1b7hc40910wlcsl36"))= )) > - (build-system python-build-system) > - (arguments > - `(#:phases > - (modify-phases %standard-phases > - (add-before > - 'build 'set-openssl-prefix > - (lambda* (#:key inputs #:allow-other-keys) > - (setenv "ATTIC_OPENSSL_PREFIX" (assoc-ref inputs "openssl")) > - #t))))) > - (inputs > - `(("acl" ,acl) > - ("openssl" ,openssl) > - ("python-msgpack" ,python-msgpack) > - > - ;; Attic is probably incompatible with llfuse > 0.41. > - ;; These links are to discussions of llfuse compatibility from > - ;; the borg project. Borg is a recent fork of attic, and attic > - ;; has not been updated since the fork, so it's likely that > - ;; llfuse compatibility requirements are still the same. > - ;; https://github.com/borgbackup/borg/issues/642 > - ;; https://github.com/borgbackup/borg/issues/643 > - ("python-llfuse" ,python-llfuse-0.41))) > - (synopsis "Deduplicating backup program") > - (description "Attic is a deduplicating backup program. The main goa= l of > -Attic is to provide an efficient and secure way to backup data. The data > -deduplication technique used makes Attic suitable for daily backups sinc= e only > -changes are stored.") > - (home-page "https://attic-backup.org/") > - (license license:bsd-3))) > - > (define-public libchop > (package > (name "libchop") > @@ -497,3 +455,46 @@ stored. The authenticated encryption technique make= s it suitable for backups > to not fully trusted targets. Borg is a fork of Attic.") > (home-page "https://borgbackup.github.io/borgbackup/") > (license license:bsd-3))) > + > +(define-public attic > + (package > + (name "attic") > + (version "0.16") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "https://pypi.python.org/packages/source/A/Attic/Att= ic-" > + version ".tar.gz")) > + (sha256 > + (base32 > + "0b5skd36r4c0915lwpkqg5hxm49gls9pprs1b7hc40910wlcsl36"))= )) > + (build-system python-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-before > + 'build 'set-openssl-prefix > + (lambda* (#:key inputs #:allow-other-keys) > + (setenv "ATTIC_OPENSSL_PREFIX" (assoc-ref inputs "openssl")) > + #t))))) > + (inputs > + `(("acl" ,acl) > + ("openssl" ,openssl) > + ("python-msgpack" ,python-msgpack) > + > + ;; Attic is probably incompatible with llfuse > 0.41. > + ;; These links are to discussions of llfuse compatibility from > + ;; the borg project. Borg is a recent fork of attic, and attic > + ;; has not been updated since the fork, so it's likely that > + ;; llfuse compatibility requirements are still the same. > + ;; https://github.com/borgbackup/borg/issues/642 > + ;; https://github.com/borgbackup/borg/issues/643 > + ("python-llfuse" ,python-llfuse-0.41))) > + (synopsis "Deduplicating backup program") > + (description "Attic is a deduplicating backup program. The main goa= l of > +Attic is to provide an efficient and secure way to backup data. The data > +deduplication technique used makes Attic suitable for daily backups sinc= e only > +changes are stored.") > + (home-page "https://attic-backup.org/") > + (license license:bsd-3) > + (properties `((superseded . ,borg))))) > --=20 > 2.10.0 >=20 shot in the dark, what if you left it in place and added (properties `((superseded . ,(delay borg)))))) --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --fwqqG+mf3f7vyBCB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJX6O4JAAoJEPTB05F+rO6TKZQQAJXzOxP21S441G4qoRIHjmTy wTE8hbH6qljhRGRvNf4BltKHBisDbtxZUe1Aa32ePUxhVS26aFUPTP6pXvO6XWCx o9L3rbvCkrCcY8lV7z0SiCHRzF8aU5M7gv/xojFNMmQaMMDVnRYGxcdDbmYc7v7u qGexi/5wpHz9eI55RcaWrz3mK50R3LcFJlWvp3wWqv9I9sUaApsk5kQqgRelfmgC GSZNvmXycmf1G1Nutg047GYMOGPBZtNdKBsYhzP4d+exgLcJZs++uoJKxqtjQHE3 15Z0EF//m3Y0RG8Hx5NI+U9An0j+1b3qudj6+PDuW4GPeHGAQzZldziIvDKuHACZ T+e/2yyDmWtpTZ91pJOXdIO93i9K4puZ6AY+cmJilpryp6IXWq9uhz9LX9spgOZL jC+RiA/VpNjgBeLxSqpCpOcqoBUu7lm0wTRx+yxwZ8yt0+5ru7BswjJxrK6ZSbON kNjIdUTVNW8hGe+M4sKLwOAA+vvduyRQI74touebfdOYQQnMI4o7a9BiUxpWf28R 0Gb7fNrb/DrZW76PTRC0vNrIO4IycRqZhuUeMjpSUqJCjCuiDJUwXDvnwE+ocHXr GcDqfhKt/xM48AUxJ/zigKdhMD1aw5A70LBT0VpsmEmjXeXIw8Vtd+B/xre43cUC sxq0wiPznc/3TcDrEVvw =mOFk -----END PGP SIGNATURE----- --fwqqG+mf3f7vyBCB--