From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add epic5. Date: Sun, 25 Sep 2016 13:13:40 -0400 Message-ID: <20160925171340.GA9499@jasmine> References: <87shsp1ma8.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HlL+5n6rz5pIUxbD" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boD00-00067w-F8 for guix-devel@gnu.org; Sun, 25 Sep 2016 13:13:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boCzw-0003U8-67 for guix-devel@gnu.org; Sun, 25 Sep 2016 13:13:55 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:33819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boCzu-0003TL-W8 for guix-devel@gnu.org; Sun, 25 Sep 2016 13:13:52 -0400 Content-Disposition: inline In-Reply-To: <87shsp1ma8.fsf@we.make.ritual.n0.is> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org --HlL+5n6rz5pIUxbD Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 24, 2016 at 01:04:47PM +0000, ng0 wrote: > I tried to get ssl working via: > - patching include/config.h > - just export the variable which was in include/config.h without > patching it. >=20 > but it seems like epic5 does something different which 'justworks=E2=84= =A2' in > ircii. epic5 is based on ircii. > If ssl is mandatory, I'll check their git repository and see if there > have been any commits recently fixing this. In general, SSL / TLS support is not mandatory for packages that do network traffic. But, users should not be misled into thinking that they are using TLS when it doesn't work. So, what happens when you use this epic5 to connect to an IRC server that uses TLS? Does it fail silently? That's not okay. > Subject: [PATCH 1/2] licenses: Add epic. >=20 > * guix/licenses.scm (epic): New variable. Does anything else use this license? If not, I would leave it out and use non-copyleft for the epic5 package license. > Subject: [PATCH 2/2] gnu: Add epic5. >=20 > * gnu/packages/irc.scm (epic5): New variable. > + (add-after 'unpack 'patch-bsdinstall > + ;; We should include this in the build-system, bsdinstall is = a standard. > + ;; If we just remove /bin/ some part of the bsdinstall breaks. > + (lambda _ > + (substitute* "bsdinstall" > + (("/bin/strip") "strip") > + (("/bin/cp") "cp") > + (("/bin/chmod") "chmod") > + (("/etc/chown") "chown") > + (("/bin/chgrp") "chgrp") > + (("/bin/mkdir") "mkdir") > + (("/bin/rm") "rm") > + (("/bin/mv") "mv") > + (("/etc/") "")))) "/etc/" is not an executable path. Do we need to substitute it here? What happens when you don't change that line? > + (zero? > + (system* "./configure" > + (string-append "--prefix=3D" out) > + "--with-ipv6" "--with-libarchive" What does it use libarchive for? What happens if we leave it out? --HlL+5n6rz5pIUxbD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX6AXEAAoJECZG+jC6yn8IBl4QANRaZGMwPsLq36JMaq48Dlhk 9bSbSdaxz3Q4j8ytHON7nWV/xU15VnCsZDHV2XHSZuCeqtHmOtIilNkHePRjGzFO KVPofZreTewsBsBfRvY2lNZ4bJ2/hjSIAYnA2t5nbpealVripgtPDxs1Cooj0kMF 6JEo408CKedEhhRNHpsPNJPnwdz+M2xusZKcFoTqc9Xek8u/RNHoFtJrMBqakZTx B6Lw0yEN4Nmi6s4toWYFcIWMoMoNPAzkFo73QK6jF3F29Ja1RWvKqk1rvjYtqm4j JlRhPtZnrVDn/HgZWmxXYaF2HFPisOk3QeZ6XWKS3idLvG4hfPPJpbyDgv+8lMDK rui9M89rctBhV80XD9v2HB0j0mw5QKgqwuTt7+J4KlrdR6eV9pzlFgeygEoYXYrE VFTCctpiifBioQSYgpaRQnRUaiCQ4j/opZZRyxNJakmy5LCGL2WV31y/P/fXV5r+ eRXVSmEaV1I+TgAfUmoqGlGYv/H+Cq5k4qkysw/qlQo09EcoitXFgA6A7yNEnsli Fmt6mdqDBHerL5fdM1R0NMucyA/bRO94oQ6eKp1VpRFLw4D63qhDs3tvLuTF2vPk PDsTC7Y9Uu2grpXGhmSR5Hp4Ttk9TWUywvYHCY8a4uk18JSzpYjQIiGziNoeaezy p0ALfgx3bwVWaXudaspZ =jOI0 -----END PGP SIGNATURE----- --HlL+5n6rz5pIUxbD--