From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: Superseded packages Date: Sun, 25 Sep 2016 12:42:08 -0400 Message-ID: <20160925164208.GA7317@jasmine> References: <874m5vvmi8.fsf@we.make.ritual.n0.is> <20160904184416.GB29947@jasmine> <87d1kirc4r.fsf@gnu.org> <87vay8r9r3.fsf_-_@gnu.org> <20160910172514.GA28562@jasmine> <87a8felfb9.fsf@gnu.org> <20160911151945.GB6400@jasmine> <87bmzujhn7.fsf@gnu.org> <20160920211833.GA3354@jasmine> <87y42if3hq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="pf9I7BMVVzbSWLtt" Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boCVZ-0007wY-B9 for guix-devel@gnu.org; Sun, 25 Sep 2016 12:42:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boCVU-0004ep-9d for guix-devel@gnu.org; Sun, 25 Sep 2016 12:42:28 -0400 Content-Disposition: inline In-Reply-To: <87y42if3hq.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?iso-8859-1?Q?Court=E8s?= Cc: guix-devel@gnu.org --pf9I7BMVVzbSWLtt Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Sat, Sep 24, 2016 at 11:14:41AM +0900, Ludovic Courtès wrote: > Leo Famulari skribis: > > +(define-public attic > > + (package (inherit borg) > > + (name "attic") > > + (properties `((superseded . ,borg))))) > > I was thinking that we could keep the ‘attic’ recipe as-is, only with > this extra ‘properties’ field. > > That way, “guix package -u” and “guix package -i attic” would install > Borg, but people who insist could still run: > > guix package -e '(@ (gnu packages backup) attic)' > > Thoughts? That's a much better idea than what I had proposed. I found that I had to move the attic package definition below borg's, or else the borg variable was unbound when building (gnu packages backup): ------ Compiling Scheme modules... LOAD (gnu packages backup) ;;; note: source file ./gnu/packages/backup.scm ;;; newer than compiled /home/leo/work/guix/gnu/packages/backup.go Backtrace: In ice-9/boot-9.scm: 2401: 19 [save-module-excursion #] 4052: 18 [#] 1724: 17 [%start-stack load-stack ...] 1729: 16 [#] In unknown file: ?: 15 [primitive-load "/home/leo/work/guix/./build-aux/compile-all.scm"] In ice-9/eval.scm: 432: 14 [eval # #] In ice-9/boot-9.scm: 768: 13 [for-each # ("gnu/packages/backup.scm")] 2864: 12 [resolve-interface (gnu packages backup) #:select ...] 2789: 11 [# # ...] 3065: 10 [try-module-autoload (gnu packages backup) #f] 2401: 9 [save-module-excursion #] 3085: 8 [#] In unknown file: ?: 7 [primitive-load-path "gnu/packages/backup" ...] In ice-9/eval.scm: 432: 6 [eval # ()] 453: 5 [eval # ()] 411: 4 [eval # #] 387: 3 [eval # #] 387: 2 [eval # #] 393: 1 [eval # #] In unknown file: ?: 0 [memoize-variable-access! # #] ERROR: In procedure memoize-variable-access!: ERROR: Unbound variable: borg ------ So the attached patch moves attic after borg and supersedes it. Is it expected that we have to shuffle the package definition around like this? --pf9I7BMVVzbSWLtt Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-gnu-attic-Superseded-by-borg.patch" >From 43a18f5c9abb22454c564ac16b2c24bf2766c220 Mon Sep 17 00:00:00 2001 From: Leo Famulari Date: Fri, 23 Sep 2016 23:36:48 -0400 Subject: [PATCH] gnu: attic: Superseded by borg. * gnu/packages/backup.scm (attic)[properties]: New field. --- gnu/packages/backup.scm | 85 +++++++++++++++++++++++++------------------------ 1 file changed, 43 insertions(+), 42 deletions(-) diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm index e77c4f2..c6f1321 100644 --- a/gnu/packages/backup.scm +++ b/gnu/packages/backup.scm @@ -358,48 +358,6 @@ to a remote location, and only the differences will be transmitted. Finally, rdiff-backup is easy to use and settings have sensible defaults.") (license license:gpl2+))) -(define-public attic - (package - (name "attic") - (version "0.16") - (source (origin - (method url-fetch) - (uri (string-append - "https://pypi.python.org/packages/source/A/Attic/Attic-" - version ".tar.gz")) - (sha256 - (base32 - "0b5skd36r4c0915lwpkqg5hxm49gls9pprs1b7hc40910wlcsl36")))) - (build-system python-build-system) - (arguments - `(#:phases - (modify-phases %standard-phases - (add-before - 'build 'set-openssl-prefix - (lambda* (#:key inputs #:allow-other-keys) - (setenv "ATTIC_OPENSSL_PREFIX" (assoc-ref inputs "openssl")) - #t))))) - (inputs - `(("acl" ,acl) - ("openssl" ,openssl) - ("python-msgpack" ,python-msgpack) - - ;; Attic is probably incompatible with llfuse > 0.41. - ;; These links are to discussions of llfuse compatibility from - ;; the borg project. Borg is a recent fork of attic, and attic - ;; has not been updated since the fork, so it's likely that - ;; llfuse compatibility requirements are still the same. - ;; https://github.com/borgbackup/borg/issues/642 - ;; https://github.com/borgbackup/borg/issues/643 - ("python-llfuse" ,python-llfuse-0.41))) - (synopsis "Deduplicating backup program") - (description "Attic is a deduplicating backup program. The main goal of -Attic is to provide an efficient and secure way to backup data. The data -deduplication technique used makes Attic suitable for daily backups since only -changes are stored.") - (home-page "https://attic-backup.org/") - (license license:bsd-3))) - (define-public libchop (package (name "libchop") @@ -497,3 +455,46 @@ stored. The authenticated encryption technique makes it suitable for backups to not fully trusted targets. Borg is a fork of Attic.") (home-page "https://borgbackup.github.io/borgbackup/") (license license:bsd-3))) + +(define-public attic + (package + (name "attic") + (version "0.16") + (source (origin + (method url-fetch) + (uri (string-append + "https://pypi.python.org/packages/source/A/Attic/Attic-" + version ".tar.gz")) + (sha256 + (base32 + "0b5skd36r4c0915lwpkqg5hxm49gls9pprs1b7hc40910wlcsl36")))) + (build-system python-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-before + 'build 'set-openssl-prefix + (lambda* (#:key inputs #:allow-other-keys) + (setenv "ATTIC_OPENSSL_PREFIX" (assoc-ref inputs "openssl")) + #t))))) + (inputs + `(("acl" ,acl) + ("openssl" ,openssl) + ("python-msgpack" ,python-msgpack) + + ;; Attic is probably incompatible with llfuse > 0.41. + ;; These links are to discussions of llfuse compatibility from + ;; the borg project. Borg is a recent fork of attic, and attic + ;; has not been updated since the fork, so it's likely that + ;; llfuse compatibility requirements are still the same. + ;; https://github.com/borgbackup/borg/issues/642 + ;; https://github.com/borgbackup/borg/issues/643 + ("python-llfuse" ,python-llfuse-0.41))) + (synopsis "Deduplicating backup program") + (description "Attic is a deduplicating backup program. The main goal of +Attic is to provide an efficient and secure way to backup data. The data +deduplication technique used makes Attic suitable for daily backups since only +changes are stored.") + (home-page "https://attic-backup.org/") + (license license:bsd-3) + (properties `((superseded . ,borg))))) -- 2.10.0 --pf9I7BMVVzbSWLtt--