all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: python-build-system: Allow build flags
Date: Thu, 22 Sep 2016 11:26:02 +0200	[thread overview]
Message-ID: <20160922112602.3193360b@scratchpost.org> (raw)
In-Reply-To: <20160922104528.4e8801a9@scratchpost.org>

> I just checked - the python-build-system doesn't allow passing flags when invoking setup.py . That's the only reason the custom build phase is there...

We could adapt python-build-system like that:

diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
index 9109fb4..6304f0c 100644
--- a/guix/build/python-build-system.scm
+++ b/guix/build/python-build-system.scm
@@ -44,9 +44,9 @@
          (zero? (apply system* "python" "setup.py" command params)))
       (error "no setup.py found")))
 
-(define* (build #:rest empty)
+(define* (build #:key (build-flags '()) #:allow-other-keys)
   "Build a given Python package."
-  (call-setuppy "build" '()))
+  (call-setuppy "build" build-flags))
 
 (define* (check #:key tests? test-target #:allow-other-keys)
   "Run the test suite of a given Python package."

How can I check which rebuilds that would cause? Seems to rebuild quite a bit on my local machine when I try to install python2-wxpython now.

  reply	other threads:[~2016-09-22  9:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-15  7:40 [PATCH] gnu: add kicad Danny Milosavljevic
2016-02-15 11:35 ` Ben Woodcroft
2016-05-23  4:13 ` Leo Famulari
2016-07-07  0:22   ` Stuck on KiCad dependency wxPython Leo Famulari
2016-07-07  6:31     ` Efraim Flashner
2016-07-08  0:51       ` Leo Famulari
2016-07-08 10:15         ` Ricardo Wurmus
2016-07-12  9:24           ` Ludovic Courtès
2016-09-22  8:27         ` Danny Milosavljevic
2016-09-22  8:45           ` Danny Milosavljevic
2016-09-22  9:26             ` Danny Milosavljevic [this message]
2016-09-22 10:43             ` [PATCH] guix: python-build-system: Honor configure-flags also when building Danny Milosavljevic
2016-09-22  9:10           ` Stuck on KiCad dependency wxPython Danny Milosavljevic
2016-09-30  0:51             ` Theodoros Foradis
2016-09-30  7:09               ` Danny Milosavljevic
2016-08-03 23:54   ` [PATCH] gnu: add kicad Danny Milosavljevic
2016-08-04  8:31     ` Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160922112602.3193360b@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.