From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 04/42] gnu: Add ghc-cryptohash. Date: Tue, 20 Sep 2016 21:10:41 -0400 Message-ID: <20160921011041.GA26508@jasmine> References: <20160918161022.26135-1-ng0@we.make.ritual.n0.is> <20160918161022.26135-4-ng0@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="T4sUOijqQbZv57TR" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmW3s-0007WX-T2 for guix-devel@gnu.org; Tue, 20 Sep 2016 21:10:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmW3n-0004nF-6L for guix-devel@gnu.org; Tue, 20 Sep 2016 21:10:56 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:60860) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmW3l-0004kK-VZ for guix-devel@gnu.org; Tue, 20 Sep 2016 21:10:51 -0400 Content-Disposition: inline In-Reply-To: <20160918161022.26135-4-ng0@we.make.ritual.n0.is> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Sep 18, 2016 at 04:09:44PM +0000, ng0 wrote: > * gnu/packages/haskell.scm (ghc-cryptohash): New variable. Thanks for this patch series! Most of the patches look good, but there are a few packages where I think the synopsis or description need to be changed. I'll attach my suggested changes to the patches that I think need them. If you agree to the changes, I can make them locally before pushing; there will be no need to send updated patches. --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-ghc-cryptohash-synopsis-description-fix.patch" >From c45d168a96f94c92e5c4eb3ffaff69931739d0e6 Mon Sep 17 00:00:00 2001 From: Leo Famulari Date: Tue, 20 Sep 2016 20:35:35 -0400 Subject: [PATCH 1/8] ghc-cryptohash synopsis description fix --- gnu/packages/haskell.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm index af7fc13..694fff1 100644 --- a/gnu/packages/haskell.scm +++ b/gnu/packages/haskell.scm @@ -6511,12 +6511,12 @@ been observed, so this library should be suitable for high performance scenarios ("ghc-tasty-quickcheck" ,ghc-tasty-quickcheck) ("ghc-tasty-hunit" ,ghc-tasty-hunit))) (home-page "http://github.com/vincenthz/hs-cryptohash") - (synopsis "Collection of crypto hashes, fast, pure and practical") + (synopsis "Collection of cryptographic hashes in Haskell") (description "A collection of crypto hashes, with a practical incremental and one-pass, pure APIs, with performance close to the fastest implementations available in other languages. The implementations are made in C with a haskell FFI wrapper -that hide the C implementation.") +that hides the C implementation.") (license license:bsd-3))) (define-public ghc-data-ordlist -- 2.10.0 --T4sUOijqQbZv57TR--