From: Leo Famulari <leo@famulari.name>
To: ng0 <ng0@we.make.ritual.n0.is>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] small patchseries to add the irc bot limnoria.
Date: Tue, 20 Sep 2016 17:38:26 -0400 [thread overview]
Message-ID: <20160920213826.GA6526@jasmine> (raw)
In-Reply-To: <871t0hjnw7.fsf@we.make.ritual.n0.is>
[-- Attachment #1: Type: text/plain, Size: 976 bytes --]
On Sun, Sep 18, 2016 at 02:14:32PM +0000, ng0 wrote:
> This is a small patchseries to add the bot limnoria, based on supybot.
Thanks!
> * gnu/packages/python.scm (python-socksipy-branch): New variable.
> + (home-page "http://code.google.com/p/socksipy-branch/")
Error 404.
> +(define-public python2-socksipy-branch
> + (package-with-python2
> + (strip-python2-variant python-socksipy-branch)))
I don't think this needs strip-python2-variant. It should be enough to
use package-with-python2.
> Subject: [PATCH 2/4] license: Add freebsd-doc.
>
> * guix/licenses.scm (freebsd-doc): New variable.
LGTM
> Subject: [PATCH 3/4] gnu: Add python-feedparser.
>
> * gnu/packages/python.scm (python-feedparser): New variable.
LGTM
> Subject: [PATCH 4/4] gnu: Add limnoria.
>
> * gnu/packages/irc.scm (limnoria): New variable.
LGTM. It would be nice to figure out how to run the tests, if they are
meant to be run by distributions.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-20 21:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 14:14 [PATCH] small patchseries to add the irc bot limnoria ng0
2016-09-18 15:59 ` Alex Vong
2016-09-18 16:17 ` ng0
2016-09-18 16:21 ` ng0
2016-09-20 21:38 ` Leo Famulari [this message]
2016-09-21 8:33 ` ng0
2016-09-21 17:22 ` ng0
2016-10-03 11:59 ` ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920213826.GA6526@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=ng0@we.make.ritual.n0.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.