From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 2/3] gnu: vlc: Add configure flags.
Date: Tue, 20 Sep 2016 16:08:05 -0400
Message-ID: <20160920200805.GA20679@jasmine>
References: <87vay4iham.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34934)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bmRL1-00089k-Uz
	for guix-devel@gnu.org; Tue, 20 Sep 2016 16:08:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bmRKx-0000Ih-OK
	for guix-devel@gnu.org; Tue, 20 Sep 2016 16:08:18 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:56811)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bmRKw-0000Ev-Fs
	for guix-devel@gnu.org; Tue, 20 Sep 2016 16:08:15 -0400
Content-Disposition: inline
In-Reply-To: <87vay4iham.fsf@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Alex Vong <alexvong1995@gmail.com>
Cc: guix-devel@gnu.org

On Sat, Sep 10, 2016 at 11:07:29AM +0800, Alex Vong wrote:
> From 066bee5d7795c6caf2376be4a38e2cf0b397ef98 Mon Sep 17 00:00:00 2001
> From: Alex Vong <alexvong1995@gmail.com>
> Date: Sat, 10 Sep 2016 00:32:03 +0800
> Subject: [PATCH 2/3] gnu: vlc: Add configure flags.
> 
> * gnu/packages/video.scm (vlc)[arguments]: Add configure flags to enable
>   most fast-math optimizations.
> ---
>  gnu/packages/video.scm | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index 858e007..a041666 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -650,7 +650,10 @@ audio/video codec library.")
>         `(;; Gross workaround for <https://trac.videolan.org/vlc/ticket/16907>.
>           ;; In our case, this led to a test failure:
>           ;;   test_libvlc_equalizer: libvlc/equalizer.c:122: test_equalizer: Assertion `isnan(libvlc_audio_equalizer_get_amp_at_index (equalizer, u_bands))' failed.
> +         ;; FIXME: This bug is fixed upstream. For now, we enable:
>           "ac_cv_c_fast_math=no"
> +         "CFLAGS=-ffast-math -fno-finite-math-only"
> +         "CXXFLAGS=-ffast-math -fno-finite-math-only"

I don't know much about this subject. Can anyone say if we can expect
this to work on all our supported architectures?