[PATCH 1/3] gnu: vlc: Add liba52 as inputs.

[PATCH 1/3] gnu: vlc: Add liba52 as inputs.

[Alex Vong]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Hi,

I split the patches into 3 parts following David's suggestion. The first
patch removes the old FIXME by adding liba52 as inputs. The second patch
adds some configure flags. The third patch adds many new inputs.

Regarding Efraim's concern of closure size, the old closure size is
1459.3 MiB, the new closure size (without samba) is 1589.5 MiB and the
new closure size (with samba) is 1681.8 MiB.

Thanks,
Alex


[-- Attachment #2: 0001-gnu-vlc-Add-liba52-as-inputs.patch --]
[-- Type: text/x-diff, Size: 1977 bytes --]

From 6ed11031c136d7cff6fef60cc8e8fdb22dfb342e Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995@gmail.com>
Date: Sat, 10 Sep 2016 00:06:26 +0800
Subject: [PATCH 1/3] gnu: vlc: Add liba52 as inputs.

* gnu/packages/video.scm (vlc)[inputs]: Add liba52.
[arguments]: Remove configure flag "--disable-a52".
---
 gnu/packages/video.scm | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 864e691..858e007 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -6,7 +6,7 @@
 ;;; Copyright © 2015, 2016 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2015 Andy Patterson <ajpatter@uwaterloo.ca>
 ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
-;;; Copyright © 2015 Alex Vong <alexvong1995@gmail.com>
+;;; Copyright © 2015, 2016 Alex Vong <alexvong1995@gmail.com>
 ;;; Copyright © 2016 Alex Griffin <a@ajgrf.com>
 ;;; Copyright © 2016 Kei Kebreau <kei@openmailbox.org>
 ;;; Copyright © 2016 Dmitry Nikolaev <cameltheman@gmail.com>
@@ -616,6 +616,7 @@ audio/video codec library.")
        ("fontconfig" ,fontconfig)
        ("freetype" ,freetype)
        ("gnutls" ,gnutls)
+       ("liba52" ,liba52)
        ("libcddb" ,libcddb)
        ("libgcrypt" ,libgcrypt)
        ("libkate" ,libkate)
@@ -646,9 +647,7 @@ audio/video codec library.")
        ("xcb-util-keysyms" ,xcb-util-keysyms)))
     (arguments
      `(#:configure-flags
-       `("--disable-a52" ; FIXME: reenable once available
-
-         ;; Gross workaround for <https://trac.videolan.org/vlc/ticket/16907>.
+       `(;; Gross workaround for <https://trac.videolan.org/vlc/ticket/16907>.
          ;; In our case, this led to a test failure:
          ;;   test_libvlc_equalizer: libvlc/equalizer.c:122: test_equalizer: Assertion `isnan(libvlc_audio_equalizer_get_amp_at_index (equalizer, u_bands))' failed.
          "ac_cv_c_fast_math=no"
-- 
2.10.0

Re: [PATCH 1/3] gnu: vlc: Add liba52 as inputs.

[Leo Famulari]

On Sat, Sep 10, 2016 at 11:06:16AM +0800, Alex Vong wrote:
> Hi,
> 
> I split the patches into 3 parts following David's suggestion. The first
> patch removes the old FIXME by adding liba52 as inputs. The second patch
> adds some configure flags. The third patch adds many new inputs.
> 
> Regarding Efraim's concern of closure size, the old closure size is
> 1459.3 MiB, the new closure size (without samba) is 1589.5 MiB and the
> new closure size (with samba) is 1681.8 MiB.
> 
> Thanks,
> Alex
> 

> From 6ed11031c136d7cff6fef60cc8e8fdb22dfb342e Mon Sep 17 00:00:00 2001
> From: Alex Vong <alexvong1995@gmail.com>
> Date: Sat, 10 Sep 2016 00:06:26 +0800
> Subject: [PATCH 1/3] gnu: vlc: Add liba52 as inputs.
> 
> * gnu/packages/video.scm (vlc)[inputs]: Add liba52.
> [arguments]: Remove configure flag "--disable-a52".

Pushed as 8824da4c8bc34b131d5920d577f406db300a921b