On Sun, Sep 18, 2016 at 05:03:14PM +0200, Hartmut Goebel wrote:
     Am 18.09.2016 um 15:57 schrieb John Darrington:
     > Does anyone have any opinions/objections before I make this commit?
     
     >           +             (string-append "--with-dlz-mysql="
     >           +                            (assoc-ref %build-inputs "mysql"))
     
     I don't think, this should be build with DLZ mysql per default. While
     DLZ is an important feature, this would urgh GuixSD users to use mysql.
     They mayprefer postgresql, though. Thus DLZ MySQL should not part of the
     default setup IMHO.

Ok.  I buy that argument.
     
     
     >           +    (outputs `("out" "utils"))
     
     Please muve this above the phases defintions. I missed this and thought
     the utils are going into the same package as the server.
     

I will do that.
     
     

-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.