From: Leo Famulari <leo@famulari.name>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 0/7] Add bioconductor package creation tools.
Date: Sat, 17 Sep 2016 19:52:04 -0400 [thread overview]
Message-ID: <20160917235204.GA21615@jasmine> (raw)
In-Reply-To: <87mvj9s8ac.fsf@gnu.org>
On Thu, Sep 15, 2016 at 01:37:47PM +0200, Roel Janssen wrote:
> In the following patch series I add packages to do package development
> for Bioconductor. They have a couple of tools to perform extra checks
> to ensure Bioconductor packages work together well.
>
> Since I am trying to add a package to Bioconductor, I need these
> packages in GNU Guix. I've been using them for a couple of days and
> it seems to work fine.
The packages look straightforward to me.
My only suggestion would be to change the descriptions to begin with
"$package is a ..." rather than "This package ...". I think it's useful
to have the package name in the description. Perhaps some of the
descriptions could give more detail, but I'm not familiar with this
software, so I can't say.
I think that if they are working for you, you've done a license audit,
and they pass `guix lint`, then they are okay.
prev parent reply other threads:[~2016-09-17 23:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 11:37 [PATCH 0/7] Add bioconductor package creation tools Roel Janssen
2016-09-17 23:52 ` Leo Famulari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160917235204.GA21615@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=roel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.