From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari <leo@famulari.name> Subject: Re: [PATCH 1/2] gnu: python: Add python-i3. Date: Fri, 16 Sep 2016 01:43:24 -0400 Message-ID: <20160916054324.GA14289@jasmine> References: <20160914091229.GA14555@sax.terramar.selidor.net> <20160914091638.GF5711@sax.terramar.selidor.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fdj2RfSjLxBAspz7" Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org> Received: from eggs.gnu.org ([2001:4830:134:3::10]:54762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <leo@famulari.name>) id 1bkm5u-000726-EJ for guix-devel@gnu.org; Fri, 16 Sep 2016 01:53:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <leo@famulari.name>) id 1bkm5n-0007xv-PR for guix-devel@gnu.org; Fri, 16 Sep 2016 01:53:47 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:34516) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <leo@famulari.name>) id 1bkm5m-0007wl-7R for guix-devel@gnu.org; Fri, 16 Sep 2016 01:53:43 -0400 Content-Disposition: inline In-Reply-To: <20160914091638.GF5711@sax.terramar.selidor.net> List-Id: "Development of GNU Guix and the GNU System distribution." <guix-devel.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>, <mailto:guix-devel-request@gnu.org?subject=unsubscribe> List-Archive: <http://lists.gnu.org/archive/html/guix-devel/> List-Post: <mailto:guix-devel@gnu.org> List-Help: <mailto:guix-devel-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>, <mailto:guix-devel-request@gnu.org?subject=subscribe> Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org> To: Ivan Vilata i Balaguer <ivan@selidor.net> Cc: guix-devel@gnu.org --fdj2RfSjLxBAspz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 14, 2016 at 11:16:38AM +0200, Ivan Vilata i Balaguer wrote: > Subject: [PATCH 1/2] gnu: python: Add python-i3. >=20 > * gnu/packages/python.scm (python-i3, python2-i3): New variables. Thank you for this patch! > +(define-public python-i3 > + (package > + (name "python-i3") I think the package should be named python-i3-py because this will be less confusing for anyone looking for i3-py. > + (version "0.6.4") As Brendan pointed out, there is a later version in the Git repo. Although we prefer to fetch from PyPi when all else is equal, we should package the latest version available. There is an example of packaging =66rom Git when there is a version number but no tags in the darkhttpd package definition. > + (build-system python-build-system) Also, it would be nice to include the README.md in 'share/doc/python-i3-py', since there's no other documentation. This can be done in a build phase after the install phase. Please reply here or ask on #guix on Freenode if you get stuck. --fdj2RfSjLxBAspz7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX24Z5AAoJECZG+jC6yn8IXKYP/ReZZiu+mFkNj1395vMF+06R 91GuhDn2MREBBlAWTmlOqMMcDosOFIsSlP8Ioy69f63TpIvTp/TcyV14p2ricxlX cTNFil+qDYMXyiwyKFF8zGruOP31iPKX3iJWCjtNJgzH/H7n1vYKXh1QJq+KV0/a aqqF/dngEeV6uLG5K9SoZPUvFnR24pyixLLvCw91Uem8qZ+r2ycxzV9JwMOjMzgB 3STjaYhcCtNMa3DoV7xujLrOWr2OyuFVTk+KXL2hvxJ9/UzYm3THMagi41C2WVvt n+JVRvkpYZs1qOu7UZ9bJ1q5msHYPyOUlMuAeY8VGUQtn2OjRXb7Jk8xxSD+HqWg 9WJLoPtyOVD8JuoQECMk+N+sBcuUuYxNpIWqw2x3sqa44piewRl9dRV2cfq9A9GK ihfSyHPC+jMCbJnI42tL+S7iHCOp5VFkWVr69l65G0Q/YfQszUTXjb5/O10FDnvL /EU9h6GtczBiGFvDgXHLlRv+v46/A1AmzhCxjNngouq8pVvSOg/HvcLTFaUC18jY rDlymVsyGpxruBWJcR4QP1J1TxWyldNDJQ11uaD0cdPSxTGRlOnRHi6Uzcx6LuuP Fou58VSZtKmWxTb9+LGrJ/MhBihAODX13AiLGskytZaF6FEDaK1cYPEh+fpBpqlf /arSacLem35cicCTCZPo =ZaQA -----END PGP SIGNATURE----- --fdj2RfSjLxBAspz7--