Re: [PATCH 1/2] gnu: python: Add python-i3.

[Leo Famulari <leo@famulari.name>]

[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]

On Wed, Sep 14, 2016 at 11:16:38AM +0200, Ivan Vilata i Balaguer wrote:
> Subject: [PATCH 1/2] gnu: python: Add python-i3.
> 
> * gnu/packages/python.scm (python-i3, python2-i3): New variables.

Thank you for this patch!

> +(define-public python-i3
> +  (package
> +    (name "python-i3")

I think the package should be named python-i3-py because this will be
less confusing for anyone looking for i3-py.

> +    (version "0.6.4")

As Brendan pointed out, there is a later version in the Git repo.
Although we prefer to fetch from PyPi when all else is equal, we should
package the latest version available. There is an example of packaging
from Git when there is a version number but no tags in the darkhttpd
package definition.

> +    (build-system python-build-system)

Also, it would be nice to include the README.md in
'share/doc/python-i3-py', since there's no other documentation. This can
be done in a build phase after the install phase. Please reply here or
ask on #guix on Freenode if you get stuck.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]