From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: [Patch 4/10] argon2: Install pkg-config file.
Date: Thu, 15 Sep 2016 23:24:12 +0200
Message-ID: <20160915232412.6bcd757b@scratchpost.org>
References: <87mvjc1quq.fsf@openmailbox.org> <8737l41qnj.fsf@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59820)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1bke8v-00062o-28
	for guix-devel@gnu.org; Thu, 15 Sep 2016 17:24:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1bke8q-0003DX-Pk
	for guix-devel@gnu.org; Thu, 15 Sep 2016 17:24:24 -0400
Received: from dd1012.kasserver.com ([85.13.128.8]:47460)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1bke8q-0003Aq-IO
	for guix-devel@gnu.org; Thu, 15 Sep 2016 17:24:20 -0400
In-Reply-To: <8737l41qnj.fsf@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Lukas Gradl <lgradl@openmailbox.org>
Cc: guix-devel@gnu.org

> +       (snippet
> +        '(let ((p (open-file "argon2.pc" "a")))
...                                          ^ why?

> +           (begin
> +             (display
> +              (string-append "prefix=/usr/local\n"
> +                             "exec_prefix=${prefix}\n"
> +                             "includedir=${prefix}/include\n"
> +                             "libdir=${prefix}/lib\n\n"
> +                             "Name: Argon2\n"
> +                             "Description: "
> +                             "The Argon2 password hashing algorithm\n"
> +                             "Version: 1.0.0\n"
> +                             "Cflags: -I${includedir}/\n"
> +                             "Libs: -L${libdir} -largon2\n") p)
> +             (close-output-port p))))

Ok but please try to upstream this as well.

> +               (zero? (system* "ln" "-s"
> +                               (string-append out "/lib/libargon2.so")
> +                               (string-append out "/lib/libargon2.so.0")))

The result of this will be ignored. Did you mean "(and ...)"?

> +               (zero? (system* ; Fix compatability for libtool based builds.
> +                       "ln" "-s"
> +                       (string-append out "/lib/libargon2.so")
> +                       (string-append out "/lib/libargon2.so.0.0.0")))))))))

Doesn't this have a soversion other than 0? I mean it's OK, I'm just asking to be sure - because the pkg-config file lists 1.0.0 and the name of the pkg-config file contains no soversion at all.