From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/2] gnu: Add femtolisp.
Date: Tue, 13 Sep 2016 15:40:32 -0400
Message-ID: <20160913194032.GA9226@jasmine>
References: <20160912135756.7185-1-ng0@we.make.ritual.n0.is>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47604)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bjtZd-0000oV-Q5
	for guix-devel@gnu.org; Tue, 13 Sep 2016 15:40:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bjtZY-0004Bb-RJ
	for guix-devel@gnu.org; Tue, 13 Sep 2016 15:40:53 -0400
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:47342)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bjtZX-00049B-Kl
	for guix-devel@gnu.org; Tue, 13 Sep 2016 15:40:48 -0400
Content-Disposition: inline
In-Reply-To: <20160912135756.7185-1-ng0@we.make.ritual.n0.is>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: ng0 <ng0@we.make.ritual.n0.is>
Cc: guix-devel@gnu.org

On Mon, Sep 12, 2016 at 01:57:55PM +0000, ng0 wrote:
> * gnu/packages/lisp.scm (femtolisp): New variable.

Thanks! Pushed with the following minor changes:

> +  (let* ((commit "68c5b1225572ecf2c52baf62f928063e5a30511b")
> +        (revision "1"))

I made it use (let) instead of (let*). The difference is described here:
https://www.gnu.org/software/guile/manual/html_node/Local-Bindings.html#index-let

> +      (version (string-append "0.0.0-" revision "-" (string-take commit 7)))
                                                    ^
I used a '.' instead of a '-', to conform with the guidelines:
https://www.gnu.org/software/guix/manual/html_node/Version-Numbers.html