From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH v4 2/3] gnu: Make ldc work again Date: Tue, 13 Sep 2016 15:25:49 -0400 Message-ID: <20160913192549.GE5986@jasmine> References: <20160913103042.7302-1-dannym@scratchpost.org> <20160913103042.7302-3-dannym@scratchpost.org> <20160913165339.GB20731@jasmine> <20160913180943.GA3862@jasmine> <87oa3rehei.fsf@mdc-berlin.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjtLK-0007Vr-D1 for guix-devel@gnu.org; Tue, 13 Sep 2016 15:26:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjtLG-0007Zz-9b for guix-devel@gnu.org; Tue, 13 Sep 2016 15:26:05 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:53900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjtLF-0007Vy-0u for guix-devel@gnu.org; Tue, 13 Sep 2016 15:26:02 -0400 Content-Disposition: inline In-Reply-To: <87oa3rehei.fsf@mdc-berlin.de> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org On Tue, Sep 13, 2016 at 09:20:05PM +0200, Ricardo Wurmus wrote: > > Leo Famulari writes: > > > On Tue, Sep 13, 2016 at 12:53:39PM -0400, Leo Famulari wrote: > >> On Tue, Sep 13, 2016 at 12:30:41PM +0200, Danny Milosavljevic wrote: > >> > * gnu/packages/ldc.scm (ldc): Added substitution. Added zlib input. Fix llvm and clang inputs to 3.7. > >> > >> LDC built with this patch. I'm currently in the test suite. If it passes > >> on my computer, I'd like to push this patch unless there are objections. > > > > The test suite passed. If there are no more comments in the next day or > > two, I will push this patch with some edits to the commit message. > > The patch looks good to me (aside from the commit message). Okay, considering the comments from you and Roel, I pushed with an altered commit message as 812b3c1f8a3717fd9fc540663912c5e9a144db5b.